Bug 134450

Summary: add registers on armv7 css jit
Product: WebKit Reporter: Alex Christensen <achristensen>
Component: CSSAssignee: Alex Christensen <achristensen>
Status: RESOLVED FIXED    
Severity: Enhancement CC: buildbot, bunhere, cdumez, commit-queue, ggaren, gyuyoung.kim, rniwa, sergio
Priority: P2    
Version: 528+ (Nightly build)   
Hardware: iPhone / iPad   
OS: Unspecified   
Attachments:
Description Flags
Patch
ggaren: review+, buildbot: commit-queue-
Archive of layout-test-results from webkit-ews-13 for mac-mountainlion-wk2 none

Description Alex Christensen 2014-06-30 12:42:29 PDT 
We can use registers beyond r7, which means we have enough registers to always compile css selectors.  Let's make this always succeed.
Comment 1 Alex Christensen 2014-06-30 12:45:01 PDT 
Created attachment 234086 [details]
Patch
Comment 2 Geoffrey Garen 2014-06-30 13:14:34 PDT 
Comment on attachment 234086 [details]
Patch

r=me
Comment 3 Build Bot 2014-06-30 13:16:42 PDT 
Comment on attachment 234086 [details]
Patch

Attachment 234086 [details] did not pass mac-wk2-ews (mac-wk2):
Output: http://webkit-queues.appspot.com/results/4695064982847488

New failing tests:
media/W3C/video/networkState/networkState_during_loadstart.html
Comment 4 Build Bot 2014-06-30 13:16:47 PDT 
Created attachment 234089 [details]
Archive of layout-test-results from webkit-ews-13 for mac-mountainlion-wk2

The attached test failures were seen while running run-webkit-tests on the mac-wk2-ews.
Bot: webkit-ews-13  Port: mac-mountainlion-wk2  Platform: Mac OS X 10.8.5
Comment 5 Alex Christensen 2014-06-30 14:28:28 PDT 
I'm pretty sure that failure was not because of this change.

I added a change to the register ranges in isValidRegister and isCallerSavedRegister and committed to http://trac.webkit.org/changeset/170598