Bug 134450

Summary:

add registers on armv7 css jit

Product:

WebKit

Reporter:

Alex Christensen <achristensen>

Component:

CSS

Assignee:

Alex Christensen <achristensen>

Status:

RESOLVED FIXED

Severity:

Enhancement

CC:

buildbot, bunhere, cdumez, commit-queue, ggaren, gyuyoung.kim, rniwa, sergio

Priority:

Version:

528+ (Nightly build)

Hardware:

iPhone / iPad

OS:

Unspecified

Attachments:

Description	Flags
Patch	ggaren: review+, buildbot: commit-queue-
Archive of layout-test-results from webkit-ews-13 for mac-mountainlion-wk2	none

Alex Christensen

Reported 2014-06-30 12:42:29 PDT

We can use registers beyond r7, which means we have enough registers to always compile css selectors. Let's make this always succeed.

Attachments
Patch (4.11 KB, patch) 2014-06-30 12:45 PDT, Alex Christensen	ggaren: review+ buildbot: commit-queue-	Details Formatted Diff Diff
Archive of layout-test-results from webkit-ews-13 for mac-mountainlion-wk2 (754.69 KB, application/zip) 2014-06-30 13:16 PDT, Build Bot	no flags	Details
View All Add attachment proposed patch, testcase, etc.

Alex Christensen

Comment 1 2014-06-30 12:45:01 PDT

Created attachment 234086 [details] Patch

Geoffrey Garen

Comment 2 2014-06-30 13:14:34 PDT

Comment on attachment 234086 [details] Patch r=me

Build Bot

Comment 3 2014-06-30 13:16:42 PDT

Comment on attachment 234086 [details] Patch Attachment 234086 [details] did not pass mac-wk2-ews (mac-wk2): Output: http://webkit-queues.appspot.com/results/4695064982847488 New failing tests: media/W3C/video/networkState/networkState_during_loadstart.html

Build Bot

Comment 4 2014-06-30 13:16:47 PDT

Created attachment 234089 [details] Archive of layout-test-results from webkit-ews-13 for mac-mountainlion-wk2 The attached test failures were seen while running run-webkit-tests on the mac-wk2-ews. Bot: webkit-ews-13 Port: mac-mountainlion-wk2 Platform: Mac OS X 10.8.5

Alex Christensen

Comment 5 2014-06-30 14:28:28 PDT

I'm pretty sure that failure was not because of this change. I added a change to the register ranges in isValidRegister and isCallerSavedRegister and committed to http://trac.webkit.org/changeset/170598

Note You need to log in before you can comment on or make changes to this bug.