Summary: | Create NSURLRequest lazily when USE(CFNETWORK) is enabled | ||||||||
---|---|---|---|---|---|---|---|---|---|
Product: | WebKit | Reporter: | Pratik Solanki <psolanki> | ||||||
Component: | Platform | Assignee: | Pratik Solanki <psolanki> | ||||||
Status: | RESOLVED FIXED | ||||||||
Severity: | Normal | CC: | bunhere, cdumez, commit-queue, gyuyoung.kim, psolanki, sergio | ||||||
Priority: | P2 | ||||||||
Version: | 528+ (Nightly build) | ||||||||
Hardware: | Unspecified | ||||||||
OS: | Unspecified | ||||||||
Bug Depends on: | 134462 | ||||||||
Bug Blocks: | |||||||||
Attachments: |
|
Description
Pratik Solanki
2014-06-29 22:16:44 PDT
Created attachment 234067 [details]
Patch
Comment on attachment 234067 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=234067&action=review > Source/WebCore/platform/network/cf/ResourceRequestCFNet.cpp:199 > + m_nsRequest = 0; nullptr? > Source/WebCore/platform/network/cf/ResourceRequestCFNet.cpp:234 > + m_nsRequest = 0; nullptr? > Source/WebCore/platform/network/cf/ResourceRequestCFNet.cpp:346 > + m_nsRequest = 0; nullptr? Committed r170578: <http://trac.webkit.org/changeset/170578> Rolling this out since it caused assertions in debug builds. Re-opened since this is blocked by bug 134462 Ah, the issue was bool encodingRequiresPlatformData() const { return m_httpBody || m_nsRequest; } Since m_nsRequest is now null until needed, encodingRequiresPlatformData() returned false and this triggered the assert. good catch. Fix will need more ifdefs in ResourceRequest.h... sigh... Created attachment 234145 [details]
Patch with assertion fix
Committed r170642: <http://trac.webkit.org/changeset/170642> |