Bug 134435

Summary:

Flags value of SourceCodeKey should be unique for each case.

Product:

WebKit

Reporter:

Daewoong Jang <daewoong.jang>

Component:

JavaScriptCore

Assignee:

Nobody <webkit-unassigned>

Status:

RESOLVED FIXED

Severity:

Normal

CC:

andersca, bfulgham, buildbot, bunhere, cdumez, commit-queue, dino, ggaren, gyuyoung.kim, rniwa, sergio

Priority:

Version:

528+ (Nightly build)

Hardware:

Unspecified

OS:

Unspecified

Attachments:

Description	Flags
patch	buildbot: commit-queue-
Archive of layout-test-results from webkit-ews-13 for mac-mountainlion-wk2	none
updated patch	buildbot: commit-queue-
Archive of layout-test-results from webkit-ews-09 for mac-mountainlion-wk2	none
updated patch	none
Archive of layout-test-results from webkit-ews-10 for mac-mountainlion-wk2	none

Daewoong Jang

Reported 2014-06-29 03:42:35 PDT

Different combinations of CodeType and JSParserStrictness could generate same m_flags value because the value of CodeType and the value of JSParserStrictness shares a bit inside m_flags member variable. Shift the value of CodeType one bit farther to the left so those values don't overlap.

Attachments
patch (1.64 KB, application/octet-stream) 2014-06-29 03:45 PDT, Daewoong Jang	buildbot: commit-queue-	Details
Archive of layout-test-results from webkit-ews-13 for mac-mountainlion-wk2 (629.87 KB, application/zip) 2014-07-01 23:30 PDT, Build Bot	no flags	Details
updated patch (1.55 KB, patch) 2014-07-02 18:05 PDT, Daewoong Jang	buildbot: commit-queue-	Details Formatted Diff Diff
Archive of layout-test-results from webkit-ews-09 for mac-mountainlion-wk2 (525.72 KB, application/zip) 2014-07-02 21:11 PDT, Build Bot	no flags	Details
updated patch (1.51 KB, patch) 2014-07-03 23:56 PDT, Daewoong Jang	no flags	Details Formatted Diff Diff
Archive of layout-test-results from webkit-ews-10 for mac-mountainlion-wk2 (642.90 KB, application/zip) 2014-07-04 01:07 PDT, Build Bot	no flags	Details
Show Obsolete (2) View All Add attachment proposed patch, testcase, etc.

Daewoong Jang

Comment 1 2014-06-29 03:45:02 PDT

Created attachment 234059 [details] patch

Build Bot

Comment 2 2014-07-01 23:30:24 PDT

Comment on attachment 234059 [details] patch Attachment 234059 [details] did not pass mac-wk2-ews (mac-wk2): Output: http://webkit-queues.appspot.com/results/5121769715269632 New failing tests: media/W3C/video/networkState/networkState_during_loadstart.html

Build Bot

Comment 3 2014-07-01 23:30:29 PDT

Created attachment 234242 [details] Archive of layout-test-results from webkit-ews-13 for mac-mountainlion-wk2 The attached test failures were seen while running run-webkit-tests on the mac-wk2-ews. Bot: webkit-ews-13 Port: mac-mountainlion-wk2 Platform: Mac OS X 10.8.5

Daewoong Jang

Comment 4 2014-07-02 18:05:26 PDT

Created attachment 234302 [details] updated patch

Build Bot

Comment 5 2014-07-02 21:11:31 PDT

Comment on attachment 234302 [details] updated patch Attachment 234302 [details] did not pass mac-wk2-ews (mac-wk2): Output: http://webkit-queues.appspot.com/results/5749145654525952 New failing tests: media/W3C/video/networkState/networkState_during_loadstart.html

Build Bot

Comment 6 2014-07-02 21:11:36 PDT

Created attachment 234314 [details] Archive of layout-test-results from webkit-ews-09 for mac-mountainlion-wk2 The attached test failures were seen while running run-webkit-tests on the mac-wk2-ews. Bot: webkit-ews-09 Port: mac-mountainlion-wk2 Platform: Mac OS X 10.8.5

Daewoong Jang

Comment 7 2014-07-03 23:56:56 PDT

Created attachment 234391 [details] updated patch

Build Bot

Comment 8 2014-07-04 01:07:30 PDT

Comment on attachment 234391 [details] updated patch Attachment 234391 [details] did not pass mac-wk2-ews (mac-wk2): Output: http://webkit-queues.appspot.com/results/5170155071995904 New failing tests: media/W3C/video/networkState/networkState_during_loadstart.html

Build Bot

Comment 9 2014-07-04 01:07:38 PDT

Created attachment 234392 [details] Archive of layout-test-results from webkit-ews-10 for mac-mountainlion-wk2 The attached test failures were seen while running run-webkit-tests on the mac-wk2-ews. Bot: webkit-ews-10 Port: mac-mountainlion-wk2 Platform: Mac OS X 10.8.5

WebKit Commit Bot

Comment 10 2014-07-06 19:07:01 PDT

Comment on attachment 234391 [details] updated patch Clearing flags on attachment: 234391 Committed r170834: <http://trac.webkit.org/changeset/170834>

WebKit Commit Bot

Comment 11 2014-07-06 19:07:08 PDT

All reviewed patches have been landed. Closing bug.

Geoffrey Garen

Comment 12 2014-07-07 11:07:57 PDT

Can you add a regression test for this?

Note You need to log in before you can comment on or make changes to this bug.