Bug 134432

Summary: [iOS][WK2] PDFs never load inline again after the Web process crashes
Product: WebKit Reporter: Tim Horton <thorton>
Component: WebKit2Assignee: Tim Horton <thorton>
Status: RESOLVED FIXED    
Severity: Normal CC: andersca, bunhere, cdumez, commit-queue, gyuyoung.kim, mitz, sam, sergio, simon.fraser
Priority: P2 Keywords: InRadar
Version: 528+ (Nightly build)   
Hardware: Unspecified   
OS: Unspecified   
Attachments:
Description Flags
patch mitz: review+

Tim Horton
Reported 2014-06-28 15:23:29 PDT
Ship mimeTypesWithCustomRepresentations over in WebPageCreationParameters so that we have it after a crash. <rdar://problem/17484205>
Attachments
patch (8.31 KB, patch)
2014-06-28 15:27 PDT, Tim Horton 		mitz: review+
DetailsFormatted DiffDiff
View All Add attachment proposed patch, testcase, etc.
Tim Horton
Comment 1 2014-06-28 15:27:06 PDT
Created attachment 234054 [details] patch
mitz
Comment 2 2014-06-28 15:31:11 PDT
Comment on attachment 234054 [details] patch View in context: https://bugs.webkit.org/attachment.cgi?id=234054&action=review > Source/WebKit2/UIProcess/Cocoa/WKWebViewContentProviderRegistry.mm:94 > + for (auto& mimeType : _contentProviderForMIMEType.keys()) > + mimeTypes.append(mimeType); Can you use copyKeysToVector to do this?
Tim Horton
Comment 3 2014-06-28 15:33:19 PDT
Comment on attachment 234054 [details] patch View in context: https://bugs.webkit.org/attachment.cgi?id=234054&action=review >> Source/WebKit2/UIProcess/Cocoa/WKWebViewContentProviderRegistry.mm:94 >> + mimeTypes.append(mimeType); > > Can you use copyKeysToVector to do this? ooh la la I've wanted that so many times and never knew it existed.
Tim Horton
Comment 4 2014-06-28 15:40:06 PDT
http://trac.webkit.org/changeset/170570
Note You need to log in before you can comment on or make changes to this bug.