Bug 134431

Summary: Remove redundant repaintCompositedLayers() parameter and its dependencies.
Product: WebKit Reporter: zalan <zalan>
Component: Layout and RenderingAssignee: zalan <zalan>
Status: RESOLVED FIXED    
Severity: Normal CC: bunhere, cdumez, commit-queue, esprehn+autocc, glenn, gyuyoung.kim, kondapallykalyan, sergio, simon.fraser
Priority: P2    
Version: 528+ (Nightly build)   
Hardware: Unspecified   
OS: Unspecified   
Attachments:
Description Flags
Patch none

zalan
Reported 2014-06-28 14:20:52 PDT
Surprisingly enough, only repaintCompositedLayers() calls recursiveRepaintLayer() and repaintCompositedLayers() passes NULL rect. It means that we never partially paint these layers.
Attachments
Patch (9.18 KB, patch)
2014-06-28 14:24 PDT, zalan 		no flags
DetailsFormatted DiffDiff
View All Add attachment proposed patch, testcase, etc.
zalan
Comment 1 2014-06-28 14:24:34 PDT
Created attachment 234052 [details] Patch
Simon Fraser (smfr)
Comment 2 2014-06-28 16:38:10 PDT
This was certainly used at some point. What's the history of this code?
zalan
Comment 3 2014-06-28 18:00:25 PDT
FrameSelection code used to call repaintCompositedLayers() with a non NULL rect. That code got heavily refactored and now it calls ::repaintUsingContainer()
WebKit Commit Bot
Comment 4 2014-06-30 11:07:20 PDT
Comment on attachment 234052 [details] Patch Clearing flags on attachment: 234052 Committed r170590: <http://trac.webkit.org/changeset/170590>
WebKit Commit Bot
Comment 5 2014-06-30 11:07:25 PDT
All reviewed patches have been landed. Closing bug.
Note You need to log in before you can comment on or make changes to this bug.