Bug 134431

Summary:

Remove redundant repaintCompositedLayers() parameter and its dependencies.

Product:

WebKit

Reporter:

zalan <zalan>

Component:

Layout and Rendering

Assignee:

zalan <zalan>

Status:

RESOLVED FIXED

Severity:

Normal

CC:

bunhere, cdumez, commit-queue, esprehn+autocc, glenn, gyuyoung.kim, kondapallykalyan, sergio, simon.fraser

Priority:

Version:

528+ (Nightly build)

Hardware:

Unspecified

OS:

Unspecified

Attachments:

Description	Flags
Patch	none

Description zalan 2014-06-28 14:20:52 PDT

Surprisingly enough, only repaintCompositedLayers() calls recursiveRepaintLayer() and repaintCompositedLayers() passes NULL rect. It means that we never partially paint these layers.

Comment 1 zalan 2014-06-28 14:24:34 PDT

Created attachment 234052 [details]
Patch

Comment 2 Simon Fraser (smfr) 2014-06-28 16:38:10 PDT

This was certainly used at some point. What's the history of this code?

Comment 3 zalan 2014-06-28 18:00:25 PDT

FrameSelection code used to call repaintCompositedLayers() with a non NULL rect. That code got heavily refactored and now it calls ::repaintUsingContainer()

Comment 4 WebKit Commit Bot 2014-06-30 11:07:20 PDT

Comment on attachment 234052 [details]
Patch

Clearing flags on attachment: 234052

Committed r170590: <http://trac.webkit.org/changeset/170590>

Comment 5 WebKit Commit Bot 2014-06-30 11:07:25 PDT

All reviewed patches have been landed.  Closing bug.