Bug 134426

Summary: [iOS WK2] position:fixed inside accelerated overflow:scroll is jumpy
Product: WebKit Reporter: Simon Fraser (smfr) <simon.fraser>
Component: New BugsAssignee: Simon Fraser (smfr) <simon.fraser>
Status: RESOLVED FIXED    
Severity: Normal CC: andersca, buildbot, bunhere, cdumez, cmarcelo, commit-queue, gyuyoung.kim, jamesr, luiz, rniwa, sergio, simon.fraser, thorton, tonikitoo, zalan
Priority: P2 Keywords: InRadar
Version: 528+ (Nightly build)   
Hardware: Unspecified   
OS: Unspecified   
Attachments:
Description Flags
Patch
thorton: review+, buildbot: commit-queue-
Archive of layout-test-results from webkit-ews-09 for mac-mountainlion-wk2 none

Description Simon Fraser (smfr) 2014-06-27 22:20:24 PDT
[iOS WK2] position:fixed inside accelerated overflow:scroll is jumpy
Comment 1 Simon Fraser (smfr) 2014-06-27 22:24:28 PDT
Created attachment 234042 [details]
Patch
Comment 2 Simon Fraser (smfr) 2014-06-27 22:25:13 PDT
<rdar://problem/17474523>
Comment 3 Tim Horton 2014-06-27 22:42:09 PDT
Comment on attachment 234042 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=234042&action=review

> Source/WebCore/page/scrolling/ScrollingTreeScrollingNode.h:-49
> -    // FIXME: We should implement this when we support ScrollingTreeScrollingNodes as children.

ha!

> Source/WebKit2/UIProcess/Scrolling/ios/ScrollingTreeOverflowScrollingNodeIOS.mm:36
> +#import <wtf/TemporaryChange.h>

this has to be sorted wrong because of case sensitivity

> Source/WebKit2/UIProcess/Scrolling/ios/ScrollingTreeOverflowScrollingNodeIOS.mm:244
> +    WTFLogAlways("scrollViewDidScroll to %.2f\n", scrollPosition.y());

I don't think so!
Comment 4 Build Bot 2014-06-27 23:29:22 PDT
Comment on attachment 234042 [details]
Patch

Attachment 234042 [details] did not pass mac-wk2-ews (mac-wk2):
Output: http://webkit-queues.appspot.com/results/5811848284733440

New failing tests:
media/W3C/video/networkState/networkState_during_loadstart.html
Comment 5 Build Bot 2014-06-27 23:29:27 PDT
Created attachment 234046 [details]
Archive of layout-test-results from webkit-ews-09 for mac-mountainlion-wk2

The attached test failures were seen while running run-webkit-tests on the mac-wk2-ews.
Bot: webkit-ews-09  Port: mac-mountainlion-wk2  Platform: Mac OS X 10.8.5
Comment 6 Simon Fraser (smfr) 2014-06-28 07:51:41 PDT
http://trac.webkit.org/changeset/170568