Bug 134426 - [iOS WK2] position:fixed inside accelerated overflow:scroll is jumpy
Summary: [iOS WK2] position:fixed inside accelerated overflow:scroll is jumpy
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: New Bugs (show other bugs)
Version: 528+ (Nightly build)
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Simon Fraser (smfr)
URL:
Keywords: InRadar
Depends on:
Blocks:
 
Reported: 2014-06-27 22:20 PDT by Simon Fraser (smfr)
Modified: 2014-06-28 07:51 PDT (History)
15 users (show)

See Also:


Attachments
Patch (11.23 KB, patch)
2014-06-27 22:24 PDT, Simon Fraser (smfr)
thorton: review+
buildbot: commit-queue-
Details | Formatted Diff | Diff
Archive of layout-test-results from webkit-ews-09 for mac-mountainlion-wk2 (529.19 KB, application/zip)
2014-06-27 23:29 PDT, Build Bot
no flags Details

Note You need to log in before you can comment on or make changes to this bug.
Description Simon Fraser (smfr) 2014-06-27 22:20:24 PDT
[iOS WK2] position:fixed inside accelerated overflow:scroll is jumpy
Comment 1 Simon Fraser (smfr) 2014-06-27 22:24:28 PDT
Created attachment 234042 [details]
Patch
Comment 2 Simon Fraser (smfr) 2014-06-27 22:25:13 PDT
<rdar://problem/17474523>
Comment 3 Tim Horton 2014-06-27 22:42:09 PDT
Comment on attachment 234042 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=234042&action=review

> Source/WebCore/page/scrolling/ScrollingTreeScrollingNode.h:-49
> -    // FIXME: We should implement this when we support ScrollingTreeScrollingNodes as children.

ha!

> Source/WebKit2/UIProcess/Scrolling/ios/ScrollingTreeOverflowScrollingNodeIOS.mm:36
> +#import <wtf/TemporaryChange.h>

this has to be sorted wrong because of case sensitivity

> Source/WebKit2/UIProcess/Scrolling/ios/ScrollingTreeOverflowScrollingNodeIOS.mm:244
> +    WTFLogAlways("scrollViewDidScroll to %.2f\n", scrollPosition.y());

I don't think so!
Comment 4 Build Bot 2014-06-27 23:29:22 PDT
Comment on attachment 234042 [details]
Patch

Attachment 234042 [details] did not pass mac-wk2-ews (mac-wk2):
Output: http://webkit-queues.appspot.com/results/5811848284733440

New failing tests:
media/W3C/video/networkState/networkState_during_loadstart.html
Comment 5 Build Bot 2014-06-27 23:29:27 PDT
Created attachment 234046 [details]
Archive of layout-test-results from webkit-ews-09 for mac-mountainlion-wk2

The attached test failures were seen while running run-webkit-tests on the mac-wk2-ews.
Bot: webkit-ews-09  Port: mac-mountainlion-wk2  Platform: Mac OS X 10.8.5
Comment 6 Simon Fraser (smfr) 2014-06-28 07:51:41 PDT
http://trac.webkit.org/changeset/170568