Bug 134423

Summary: [Win] Fix Leak in WebCore::createGlobalImageFileDescriptor
Product: WebKit Reporter: Brent Fulgham <bfulgham>
Component: WebCore Misc.Assignee: Brent Fulgham <bfulgham>
Status: RESOLVED FIXED    
Severity: Normal CC: bfulgham, buildbot, bunhere, cdumez, commit-queue, ddkilzer, gyuyoung.kim, rniwa, sergio
Priority: P2 Keywords: InRadar
Version: 528+ (Nightly build)   
Hardware: PC   
OS: All   
Attachments:
Description Flags
Patch
none
Patch
none
Patch
ggaren: review+, buildbot: commit-queue-
Archive of layout-test-results from webkit-ews-16 for mac-mountainlion-wk2 none

Brent Fulgham
Reported 2014-06-27 17:39:32 PDT
createGlobalImageFileDescriptor can leak a FILEGROUPDESCRIPTOR (HGLOBAL) in an error case..
Attachments
Patch (1.97 KB, patch)
2014-06-27 17:41 PDT, Brent Fulgham 		no flags
DetailsFormatted DiffDiff
Patch (4.95 KB, patch)
2014-06-27 18:07 PDT, Brent Fulgham 		no flags
DetailsFormatted DiffDiff
Patch (4.99 KB, patch)
2014-06-30 10:51 PDT, Brent Fulgham 		ggaren: review+
buildbot: commit-queue-
DetailsFormatted DiffDiff
Archive of layout-test-results from webkit-ews-16 for mac-mountainlion-wk2 (665.20 KB, application/zip)
2014-06-30 12:00 PDT, Build Bot 		no flags
Details
Show Obsolete (2) View All Add attachment proposed patch, testcase, etc.
Brent Fulgham
Comment 1 2014-06-27 17:39:44 PDT
<rdar://problem/17492758>
Brent Fulgham
Comment 2 2014-06-27 17:41:33 PDT
Created attachment 234035 [details] Patch
Brent Fulgham
Comment 3 2014-06-27 18:07:35 PDT
Created attachment 234036 [details] Patch
Brent Fulgham
Comment 4 2014-06-27 18:08:50 PDT
Fixed a few other things identified in the same file.
Brent Fulgham
Comment 5 2014-06-30 10:51:36 PDT
Created attachment 234080 [details] Patch
Geoffrey Garen
Comment 6 2014-06-30 11:24:31 PDT
Comment on attachment 234080 [details] Patch r=me When does this failure occur? Can you create a regression test for it?
Build Bot
Comment 7 2014-06-30 12:00:03 PDT
Comment on attachment 234080 [details] Patch Attachment 234080 [details] did not pass mac-wk2-ews (mac-wk2): Output: http://webkit-queues.appspot.com/results/4544576308117504 New failing tests: media/W3C/video/networkState/networkState_during_loadstart.html
Build Bot
Comment 8 2014-06-30 12:00:08 PDT
Created attachment 234085 [details] Archive of layout-test-results from webkit-ews-16 for mac-mountainlion-wk2 The attached test failures were seen while running run-webkit-tests on the mac-wk2-ews. Bot: webkit-ews-16 Port: mac-mountainlion-wk2 Platform: Mac OS X 10.8.5
Brent Fulgham
Comment 9 2014-07-22 12:37:26 PDT
Committed r171353: <http://trac.webkit.org/changeset/171353>
Note You need to log in before you can comment on or make changes to this bug.