Bug 134410

Summary: InfoClick (from Nisus Software) dies on viewing found items
Product: WebKit Reporter: Sam Weinig <sam>
Component: New BugsAssignee: Sam Weinig <sam>
Status: RESOLVED FIXED    
Severity: Normal CC: bunhere, cdumez, commit-queue, gyuyoung.kim, sergio
Priority: P2    
Version: 528+ (Nightly build)   
Hardware: Unspecified   
OS: Unspecified   
Attachments:
Description Flags
Patch aestes: review+

Sam Weinig
Reported 2014-06-27 13:59:28 PDT
InfoClick (from Nisus Software) dies on viewing found items
Attachments
Patch (1.87 KB, patch)
2014-06-27 14:02 PDT, Sam Weinig 		aestes: review+
DetailsFormatted DiffDiff
View All Add attachment proposed patch, testcase, etc.
Sam Weinig
Comment 1 2014-06-27 14:02:01 PDT
Created attachment 234014 [details] Patch
Sam Weinig
Comment 2 2014-06-27 14:05:01 PDT
Committed revision 170552.
Andy Estes
Comment 3 2014-06-27 14:12:04 PDT
Comment on attachment 234014 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=234014&action=review > Source/WebKit/mac/ChangeLog:18 > + (+[WebPreferences _switchNetworkLoaderToNewTestingSession]): > + Remove now unnecessary call to InitWebCoreSystemInterface(). Wait, why is this now unnecessary? +initialize doesn't call +_switchNetworkLoaderToNewTestingSession.
Sam Weinig
Comment 4 2014-06-27 17:31:24 PDT
(In reply to comment #3) > (From update of attachment 234014 [details]) > View in context: https://bugs.webkit.org/attachment.cgi?id=234014&action=review > > > Source/WebKit/mac/ChangeLog:18 > > + (+[WebPreferences _switchNetworkLoaderToNewTestingSession]): > > + Remove now unnecessary call to InitWebCoreSystemInterface(). > > Wait, why is this now unnecessary? +initialize doesn't call +_switchNetworkLoaderToNewTestingSession. +initialize is guaranteed to be called will be called before +_switchNetworkLoaderToNewTestingSession by the runtime.
Note You need to log in before you can comment on or make changes to this bug.