Bug 134407

Summary: Lazily link frameworks in WebVideoFullscreenInterfaceAVKit.
Product: WebKit Reporter: Jeremy Jones <jeremyj-wk>
Component: MediaAssignee: Jeremy Jones <jeremyj-wk>
Status: RESOLVED FIXED    
Severity: Normal CC: buildbot, bunhere, cdumez, commit-queue, eric.carlson, glenn, gyuyoung.kim, jer.noble, philipj, rniwa, sergio
Priority: P2    
Version: 528+ (Nightly build)   
Hardware: iPhone / iPad   
OS: Unspecified   
Attachments:
Description Flags
Patch
eric.carlson: review+, buildbot: commit-queue-
Archive of layout-test-results from webkit-ews-09 for mac-mountainlion-wk2
none
Patch for landing. none

Description Jeremy Jones 2014-06-27 12:41:26 PDT
Lazily link frameworks in WebVideoFullscreenInterfaceAVKit.
Comment 1 Jeremy Jones 2014-06-27 12:42:07 PDT
<rdar://problem/17441412>
Comment 2 Jeremy Jones 2014-06-27 12:46:23 PDT
Created attachment 234008 [details]
Patch
Comment 3 Eric Carlson 2014-06-27 12:50:34 PDT
Comment on attachment 234008 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=234008&action=review

> Source/WebCore/ChangeLog:10
> +        Link AVPlayerController on use.

Nit: *Load" instead of *Link*?

> Source/WebCore/ChangeLog:15
> +        Remove linking on construction.
> +        (WebVideoFullscreenInterfaceAVKit::setCurrentTime): Link AVValueTiming on use.
> +        (WebVideoFullscreenInterfaceAVKit::setupFullscreen): Link several classes on use.
> +        (WebVideoFullscreenInterfaceAVKit::exitFullscreen): Link UIColor on use.

Ditto.
Comment 4 Build Bot 2014-06-27 13:21:20 PDT
Comment on attachment 234008 [details]
Patch

Attachment 234008 [details] did not pass mac-wk2-ews (mac-wk2):
Output: http://webkit-queues.appspot.com/results/6575937437040640

New failing tests:
media/W3C/video/src/src_reflects_attribute_not_source_elements.html
Comment 5 Build Bot 2014-06-27 13:21:24 PDT
Created attachment 234009 [details]
Archive of layout-test-results from webkit-ews-09 for mac-mountainlion-wk2

The attached test failures were seen while running run-webkit-tests on the mac-wk2-ews.
Bot: webkit-ews-09  Port: mac-mountainlion-wk2  Platform: Mac OS X 10.8.5
Comment 6 Jeremy Jones 2014-06-27 13:22:14 PDT
Created attachment 234010 [details]
Patch for landing.
Comment 7 WebKit Commit Bot 2014-06-27 16:28:58 PDT
Comment on attachment 234010 [details]
Patch for landing.

Clearing flags on attachment: 234010

Committed r170560: <http://trac.webkit.org/changeset/170560>