Bug 134407

Summary: Lazily link frameworks in WebVideoFullscreenInterfaceAVKit.
Product: WebKit Reporter: Jeremy Jones <jeremyj-wk>
Component: MediaAssignee: Jeremy Jones <jeremyj-wk>
Status: RESOLVED FIXED    
Severity: Normal CC: buildbot, bunhere, cdumez, commit-queue, eric.carlson, glenn, gyuyoung.kim, jer.noble, philipj, rniwa, sergio
Priority: P2    
Version: 528+ (Nightly build)   
Hardware: iPhone / iPad   
OS: Unspecified   
Attachments:
Description Flags
Patch
eric.carlson: review+, buildbot: commit-queue-
Archive of layout-test-results from webkit-ews-09 for mac-mountainlion-wk2
none
Patch for landing. none

Jeremy Jones
Reported 2014-06-27 12:41:26 PDT
Lazily link frameworks in WebVideoFullscreenInterfaceAVKit.
Attachments
Patch (4.80 KB, patch)
2014-06-27 12:46 PDT, Jeremy Jones 		eric.carlson: review+
buildbot: commit-queue-
DetailsFormatted DiffDiff
Archive of layout-test-results from webkit-ews-09 for mac-mountainlion-wk2 (720.85 KB, application/zip)
2014-06-27 13:21 PDT, Build Bot 		no flags
Details
Patch for landing. (4.80 KB, patch)
2014-06-27 13:22 PDT, Jeremy Jones 		no flags
DetailsFormatted DiffDiff
View All Add attachment proposed patch, testcase, etc.
Jeremy Jones
Comment 1 2014-06-27 12:42:07 PDT
<rdar://problem/17441412>
Jeremy Jones
Comment 2 2014-06-27 12:46:23 PDT
Created attachment 234008 [details] Patch
Eric Carlson
Comment 3 2014-06-27 12:50:34 PDT
Comment on attachment 234008 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=234008&action=review > Source/WebCore/ChangeLog:10 > + Link AVPlayerController on use. Nit: *Load" instead of *Link*? > Source/WebCore/ChangeLog:15 > + Remove linking on construction. > + (WebVideoFullscreenInterfaceAVKit::setCurrentTime): Link AVValueTiming on use. > + (WebVideoFullscreenInterfaceAVKit::setupFullscreen): Link several classes on use. > + (WebVideoFullscreenInterfaceAVKit::exitFullscreen): Link UIColor on use. Ditto.
Build Bot
Comment 4 2014-06-27 13:21:20 PDT
Comment on attachment 234008 [details] Patch Attachment 234008 [details] did not pass mac-wk2-ews (mac-wk2): Output: http://webkit-queues.appspot.com/results/6575937437040640 New failing tests: media/W3C/video/src/src_reflects_attribute_not_source_elements.html
Build Bot
Comment 5 2014-06-27 13:21:24 PDT
Created attachment 234009 [details] Archive of layout-test-results from webkit-ews-09 for mac-mountainlion-wk2 The attached test failures were seen while running run-webkit-tests on the mac-wk2-ews. Bot: webkit-ews-09 Port: mac-mountainlion-wk2 Platform: Mac OS X 10.8.5
Jeremy Jones
Comment 6 2014-06-27 13:22:14 PDT
Created attachment 234010 [details] Patch for landing.
WebKit Commit Bot
Comment 7 2014-06-27 16:28:58 PDT
Comment on attachment 234010 [details] Patch for landing. Clearing flags on attachment: 234010 Committed r170560: <http://trac.webkit.org/changeset/170560>
Note You need to log in before you can comment on or make changes to this bug.