Summary: | Lazily link frameworks in WebVideoFullscreenInterfaceAVKit. | ||||||||||
---|---|---|---|---|---|---|---|---|---|---|---|
Product: | WebKit | Reporter: | Jeremy Jones <jeremyj-wk> | ||||||||
Component: | Media | Assignee: | Jeremy Jones <jeremyj-wk> | ||||||||
Status: | RESOLVED FIXED | ||||||||||
Severity: | Normal | CC: | buildbot, bunhere, cdumez, commit-queue, eric.carlson, glenn, gyuyoung.kim, jer.noble, philipj, rniwa, sergio | ||||||||
Priority: | P2 | ||||||||||
Version: | 528+ (Nightly build) | ||||||||||
Hardware: | iPhone / iPad | ||||||||||
OS: | Unspecified | ||||||||||
Attachments: |
|
Description
Jeremy Jones
2014-06-27 12:41:26 PDT
Created attachment 234008 [details]
Patch
Comment on attachment 234008 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=234008&action=review > Source/WebCore/ChangeLog:10 > + Link AVPlayerController on use. Nit: *Load" instead of *Link*? > Source/WebCore/ChangeLog:15 > + Remove linking on construction. > + (WebVideoFullscreenInterfaceAVKit::setCurrentTime): Link AVValueTiming on use. > + (WebVideoFullscreenInterfaceAVKit::setupFullscreen): Link several classes on use. > + (WebVideoFullscreenInterfaceAVKit::exitFullscreen): Link UIColor on use. Ditto. Comment on attachment 234008 [details] Patch Attachment 234008 [details] did not pass mac-wk2-ews (mac-wk2): Output: http://webkit-queues.appspot.com/results/6575937437040640 New failing tests: media/W3C/video/src/src_reflects_attribute_not_source_elements.html Created attachment 234009 [details]
Archive of layout-test-results from webkit-ews-09 for mac-mountainlion-wk2
The attached test failures were seen while running run-webkit-tests on the mac-wk2-ews.
Bot: webkit-ews-09 Port: mac-mountainlion-wk2 Platform: Mac OS X 10.8.5
Created attachment 234010 [details]
Patch for landing.
Comment on attachment 234010 [details] Patch for landing. Clearing flags on attachment: 234010 Committed r170560: <http://trac.webkit.org/changeset/170560> |