Bug 134407 - Lazily link frameworks in WebVideoFullscreenInterfaceAVKit.
Summary: Lazily link frameworks in WebVideoFullscreenInterfaceAVKit.
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: Media (show other bugs)
Version: 528+ (Nightly build)
Hardware: iPhone / iPad Unspecified
: P2 Normal
Assignee: Jeremy Jones
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2014-06-27 12:41 PDT by Jeremy Jones
Modified: 2014-06-30 12:28 PDT (History)
11 users (show)

See Also:

Attachments
Patch (4.80 KB, patch)
2014-06-27 12:46 PDT, Jeremy Jones 		eric.carlson: review+
buildbot: commit-queue-
Details | Formatted Diff | Diff
Archive of layout-test-results from webkit-ews-09 for mac-mountainlion-wk2 (720.85 KB, application/zip)
2014-06-27 13:21 PDT, Build Bot 		no flags Details
Patch for landing. (4.80 KB, patch)
2014-06-27 13:22 PDT, Jeremy Jones 		no flags Details | Formatted Diff | Diff
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Jeremy Jones 2014-06-27 12:41:26 PDT 
Lazily link frameworks in WebVideoFullscreenInterfaceAVKit.
Comment 1 Jeremy Jones 2014-06-27 12:42:07 PDT 
<rdar://problem/17441412>
Comment 2 Jeremy Jones 2014-06-27 12:46:23 PDT 
Created attachment 234008 [details]
Patch
Comment 3 Eric Carlson 2014-06-27 12:50:34 PDT 
Comment on attachment 234008 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=234008&action=review

> Source/WebCore/ChangeLog:10
> +        Link AVPlayerController on use.

Nit: *Load" instead of *Link*?

> Source/WebCore/ChangeLog:15
> +        Remove linking on construction.
> +        (WebVideoFullscreenInterfaceAVKit::setCurrentTime): Link AVValueTiming on use.
> +        (WebVideoFullscreenInterfaceAVKit::setupFullscreen): Link several classes on use.
> +        (WebVideoFullscreenInterfaceAVKit::exitFullscreen): Link UIColor on use.

Ditto.
Comment 4 Build Bot 2014-06-27 13:21:20 PDT 
Comment on attachment 234008 [details]
Patch

Attachment 234008 [details] did not pass mac-wk2-ews (mac-wk2):
Output: http://webkit-queues.appspot.com/results/6575937437040640

New failing tests:
media/W3C/video/src/src_reflects_attribute_not_source_elements.html
Comment 5 Build Bot 2014-06-27 13:21:24 PDT 
Created attachment 234009 [details]
Archive of layout-test-results from webkit-ews-09 for mac-mountainlion-wk2

The attached test failures were seen while running run-webkit-tests on the mac-wk2-ews.
Bot: webkit-ews-09  Port: mac-mountainlion-wk2  Platform: Mac OS X 10.8.5
Comment 6 Jeremy Jones 2014-06-27 13:22:14 PDT 
Created attachment 234010 [details]
Patch for landing.
Comment 7 WebKit Commit Bot 2014-06-27 16:28:58 PDT 
Comment on attachment 234010 [details]
Patch for landing.

Clearing flags on attachment: 234010

Committed r170560: <http://trac.webkit.org/changeset/170560>