Bug 134395

Summary: Add myself to contributors.json.
Product: WebKit Reporter: Sungmann Cho <sungmann.cho>
Component: New BugsAssignee: Nobody <webkit-unassigned>
Status: RESOLVED INVALID    
Severity: Normal CC: bunhere, cdumez, commit-queue, glenn, gyuyoung.kim, sergio
Priority: P2    
Version: 528+ (Nightly build)   
Hardware: Unspecified   
OS: Unspecified   
Attachments:
Description Flags
Patch
none
Patch ap: review-, ap: commit-queue-

Description Sungmann Cho 2014-06-27 06:23:20 PDT
Add myself to contributors.json.
Comment 1 Sungmann Cho 2014-06-27 06:24:01 PDT
Created attachment 233979 [details]
Patch
Comment 2 WebKit Commit Bot 2014-06-27 06:26:48 PDT
Attachment 233979 [details] did not pass style-queue:


ERROR: Tools/Scripts/webkitpy/common/config/contributors.json:0:  contributors.json should not be modified through the commit queue  [json/syntax] [5]
Total errors found: 1 in 2 files


If any of these errors are false positives, please file a bug against check-webkit-style.
Comment 3 Sungmann Cho 2014-06-27 06:29:41 PDT
*** Bug 134394 has been marked as a duplicate of this bug. ***
Comment 4 Csaba Osztrogonác 2014-06-27 07:03:35 PDT
Comment on attachment 233979 [details]
Patch

Please don't add yourself to the list of reviewers, but contributors.
Comment 5 Sungmann Cho 2014-06-27 07:12:44 PDT
Created attachment 233981 [details]
Patch
Comment 6 WebKit Commit Bot 2014-06-27 07:14:52 PDT
Attachment 233981 [details] did not pass style-queue:


ERROR: Tools/Scripts/webkitpy/common/config/contributors.json:0:  contributors.json should not be modified through the commit queue  [json/syntax] [5]
Total errors found: 1 in 2 files


If any of these errors are false positives, please file a bug against check-webkit-style.
Comment 7 Alexey Proskuryakov 2014-06-27 11:56:09 PDT
Comment on attachment 233981 [details]
Patch

> contributors.json should not be modified through the commit queue

Yes, what the bot said.

The purpose of contributor list is to enable Bugzilla autocomplete, so when a committer finds themselves CC'ing you on bugs often, they can add you to the list.