Bug 134395

Summary: Add myself to contributors.json.
Product: WebKit Reporter: Sungmann Cho <sungmann.cho>
Component: New BugsAssignee: Nobody <webkit-unassigned>
Status: RESOLVED INVALID    
Severity: Normal CC: bunhere, cdumez, commit-queue, glenn, gyuyoung.kim, sergio
Priority: P2    
Version: 528+ (Nightly build)   
Hardware: Unspecified   
OS: Unspecified   
Attachments:
Description Flags
Patch
none
Patch ap: review-, ap: commit-queue-

Sungmann Cho
Reported 2014-06-27 06:23:20 PDT
Add myself to contributors.json.
Attachments
Patch (1.08 KB, patch)
2014-06-27 06:24 PDT, Sungmann Cho 		no flags
DetailsFormatted DiffDiff
Patch (1.08 KB, patch)
2014-06-27 07:12 PDT, Sungmann Cho 		ap: review-
ap: commit-queue-
DetailsFormatted DiffDiff
Show Obsolete (1) View All Add attachment proposed patch, testcase, etc.
Sungmann Cho
Comment 1 2014-06-27 06:24:01 PDT
Created attachment 233979 [details] Patch
WebKit Commit Bot
Comment 2 2014-06-27 06:26:48 PDT
Attachment 233979 [details] did not pass style-queue: ERROR: Tools/Scripts/webkitpy/common/config/contributors.json:0: contributors.json should not be modified through the commit queue [json/syntax] [5] Total errors found: 1 in 2 files If any of these errors are false positives, please file a bug against check-webkit-style.
Sungmann Cho
Comment 3 2014-06-27 06:29:41 PDT
*** Bug 134394 has been marked as a duplicate of this bug. ***
Csaba Osztrogonác
Comment 4 2014-06-27 07:03:35 PDT
Comment on attachment 233979 [details] Patch Please don't add yourself to the list of reviewers, but contributors.
Sungmann Cho
Comment 5 2014-06-27 07:12:44 PDT
Created attachment 233981 [details] Patch
WebKit Commit Bot
Comment 6 2014-06-27 07:14:52 PDT
Attachment 233981 [details] did not pass style-queue: ERROR: Tools/Scripts/webkitpy/common/config/contributors.json:0: contributors.json should not be modified through the commit queue [json/syntax] [5] Total errors found: 1 in 2 files If any of these errors are false positives, please file a bug against check-webkit-style.
Alexey Proskuryakov
Comment 7 2014-06-27 11:56:09 PDT
Comment on attachment 233981 [details] Patch > contributors.json should not be modified through the commit queue Yes, what the bot said. The purpose of contributor list is to enable Bugzilla autocomplete, so when a committer finds themselves CC'ing you on bugs often, they can add you to the list.
Note You need to log in before you can comment on or make changes to this bug.