Bug 134390

Summary: [GTK] Use public getter/setter in GObject DOM bindings properties implementation
Product: WebKit Reporter: Carlos Garcia Campos <cgarcia>
Component: BindingsAssignee: Nobody <webkit-unassigned>
Status: RESOLVED FIXED    
Severity: Normal CC: alecflett, buildbot, bunhere, cdumez, commit-queue, gyuyoung.kim, jsbell, rniwa, sergio
Priority: P2 Keywords: Gtk
Version: 528+ (Nightly build)   
Hardware: Unspecified   
OS: Unspecified   
Attachments:
Description Flags
Patch
none
Archive of layout-test-results from webkit-ews-16 for mac-mountainlion-wk2 none

Carlos Garcia Campos
Reported 2014-06-27 03:19:40 PDT
We are currently duplicating the code in the get/set_property methods and the public getter/setters, making both the code generator and the generated code more complicated.
Attachments
Patch (65.39 KB, patch)
2014-06-27 14:53 PDT, Juan A. Suarez 		no flags
DetailsFormatted DiffDiff
Archive of layout-test-results from webkit-ews-16 for mac-mountainlion-wk2 (578.79 KB, application/zip)
2014-06-27 15:39 PDT, Build Bot 		no flags
Details
View All Add attachment proposed patch, testcase, etc.
Juan A. Suarez
Comment 1 2014-06-27 14:53:56 PDT
Created attachment 234020 [details] Patch
Build Bot
Comment 2 2014-06-27 15:39:03 PDT
Comment on attachment 234020 [details] Patch Attachment 234020 [details] did not pass mac-wk2-ews (mac-wk2): Output: http://webkit-queues.appspot.com/results/6534453446836224 New failing tests: media/W3C/video/networkState/networkState_during_loadstart.html
Build Bot
Comment 3 2014-06-27 15:39:07 PDT
Created attachment 234028 [details] Archive of layout-test-results from webkit-ews-16 for mac-mountainlion-wk2 The attached test failures were seen while running run-webkit-tests on the mac-wk2-ews. Bot: webkit-ews-16 Port: mac-mountainlion-wk2 Platform: Mac OS X 10.8.5
WebKit Commit Bot
Comment 4 2014-06-28 02:06:39 PDT
Comment on attachment 234020 [details] Patch Clearing flags on attachment: 234020 Committed r170567: <http://trac.webkit.org/changeset/170567>
WebKit Commit Bot
Comment 5 2014-06-28 02:06:45 PDT
All reviewed patches have been landed. Closing bug.
Note You need to log in before you can comment on or make changes to this bug.