Bug 134390

Summary:

[GTK] Use public getter/setter in GObject DOM bindings properties implementation

Product:

WebKit

Reporter:

Carlos Garcia Campos <cgarcia>

Component:

Bindings

Assignee:

Nobody <webkit-unassigned>

Status:

RESOLVED FIXED

Severity:

Normal

CC:

alecflett, buildbot, bunhere, cdumez, commit-queue, gyuyoung.kim, jsbell, rniwa, sergio

Priority:

Keywords:

Gtk

Version:

528+ (Nightly build)

Hardware:

Unspecified

OS:

Unspecified

Attachments:

Description	Flags
Patch	none
Archive of layout-test-results from webkit-ews-16 for mac-mountainlion-wk2	none

Description Carlos Garcia Campos 2014-06-27 03:19:40 PDT

We are currently duplicating the code in the get/set_property methods and the public getter/setters, making both the code generator and the generated code more complicated.

Comment 1 Juan A. Suarez 2014-06-27 14:53:56 PDT

Created attachment 234020 [details]
Patch

Comment 2 Build Bot 2014-06-27 15:39:03 PDT

Comment on attachment 234020 [details]
Patch

Attachment 234020 [details] did not pass mac-wk2-ews (mac-wk2):
Output: http://webkit-queues.appspot.com/results/6534453446836224

New failing tests:
media/W3C/video/networkState/networkState_during_loadstart.html

Comment 3 Build Bot 2014-06-27 15:39:07 PDT

Created attachment 234028 [details]
Archive of layout-test-results from webkit-ews-16 for mac-mountainlion-wk2

The attached test failures were seen while running run-webkit-tests on the mac-wk2-ews.
Bot: webkit-ews-16  Port: mac-mountainlion-wk2  Platform: Mac OS X 10.8.5

Comment 4 WebKit Commit Bot 2014-06-28 02:06:39 PDT

Comment on attachment 234020 [details]
Patch

Clearing flags on attachment: 234020

Committed r170567: <http://trac.webkit.org/changeset/170567>

Comment 5 WebKit Commit Bot 2014-06-28 02:06:45 PDT

All reviewed patches have been landed.  Closing bug.