Bug 134364 – DOM attributes on prototypes should be configurable

• Component: JavaScriptCore
• Status: RESOLVED FIXED

[Mark Hahnenberg]

Currently they're not due to the internal implementation of CustomGetters/CustomSetters vs. normal Getters/Setters. Allowing mixing of Custom and non-Custom Getters and Setters in the same slot will enable attributes on the prototype to be configurable.

[Chris Dumez]

Created attachment 261685 [details]
Patch

[Build Bot]

Comment on attachment 261685 [details]
Patch

Attachment 261685 [details] did not pass mac-ews (mac):
Output: http://webkit-queues.webkit.org/results/194514

New failing tests:
imported/w3c/web-platform-tests/html/semantics/embedded-content/the-canvas-element/type.delete.html
js/dom/getOwnPropertyDescriptor.html
js/dom/global-constructors-attributes.html
imported/w3c/canvas/2d.type.delete.html
js/dom/global-constructors-deletable.html
js/dom/global-constructors-attributes-dedicated-worker.html
imported/w3c/web-platform-tests/dom/interface-objects.html
js/dom/global-constructors-attributes-idb.html
imported/w3c/web-platform-tests/dom/interfaces.html
imported/w3c/web-platform-tests/html/dom/interfaces.html
imported/w3c/canvas/type.delete.html

[Build Bot]

Created attachment 261689 [details]
Archive of layout-test-results from ews103 for mac-mavericks

The attached test failures were seen while running run-webkit-tests on the mac-ews.
Bot: ews103  Port: mac-mavericks  Platform: Mac OS X 10.9.5

[Build Bot]

Comment on attachment 261685 [details]
Patch

Attachment 261685 [details] did not pass mac-wk2-ews (mac-wk2):
Output: http://webkit-queues.webkit.org/results/194515

New failing tests:
imported/w3c/web-platform-tests/html/semantics/embedded-content/the-canvas-element/type.delete.html
js/dom/getOwnPropertyDescriptor.html
js/dom/global-constructors-attributes.html
imported/w3c/canvas/2d.type.delete.html
js/dom/global-constructors-attributes-dedicated-worker.html
js/dom/global-constructors-deletable.html
imported/w3c/web-platform-tests/dom/interface-objects.html
js/dom/global-constructors-attributes-idb.html
imported/w3c/web-platform-tests/dom/interfaces.html
imported/w3c/web-platform-tests/html/dom/interfaces.html
imported/w3c/canvas/type.delete.html

[Build Bot]

Created attachment 261690 [details]
Archive of layout-test-results from ews105 for mac-mavericks-wk2

The attached test failures were seen while running run-webkit-tests on the mac-wk2-ews.
Bot: ews105  Port: mac-mavericks-wk2  Platform: Mac OS X 10.9.5

[Chris Dumez]

Created attachment 261699 [details]
Patch

[Chris Dumez]

Created attachment 261700 [details]
Patch

[Sam Weinig]

Comment on attachment 261700 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=261700&action=review

> LayoutTests/fast/dom/attributes-configurable.html:10
> +shouldBeTrue("event.__proto__.hasOwnProperty('eventPhase')");

Seems useful to also have a test that checks the result of Object.getOwnPropertyDescriptor. (something like, Object.getOwnPropertyDescriptor(event.__proto__, "eventPhase").configurable).

[Chris Dumez]

Comment on attachment 261700 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=261700&action=review

>> LayoutTests/fast/dom/attributes-configurable.html:10
>> +shouldBeTrue("event.__proto__.hasOwnProperty('eventPhase')");
> 
> Seems useful to also have a test that checks the result of Object.getOwnPropertyDescriptor. (something like, Object.getOwnPropertyDescriptor(event.__proto__, "eventPhase").configurable).

Right, will do. Thanks.

[Chris Dumez]

Created attachment 261721 [details]
Patch

[WebKit Commit Bot]

Comment on attachment 261721 [details]
Patch

Clearing flags on attachment: 261721

Committed r190104: <http://trac.webkit.org/changeset/190104>

[WebKit Commit Bot]

All reviewed patches have been landed.  Closing bug.