| Summary: | XHR should keep attributes on instance | ||||||||||
|---|---|---|---|---|---|---|---|---|---|---|---|
| Product: | WebKit | Reporter: | Mark Hahnenberg <mhahnenberg> | ||||||||
| Component: | JavaScriptCore | Assignee: | Mark Hahnenberg <mhahnenberg> | ||||||||
| Status: | RESOLVED FIXED | ||||||||||
| Severity: | Normal | CC: | buildbot, bunhere, cdumez, cgarcia, commit-queue, dbates, ggaren, gyuyoung.kim, oliver, rniwa, sergio | ||||||||
| Priority: | P2 | ||||||||||
| Version: | 528+ (Nightly build) | ||||||||||
| Hardware: | Unspecified | ||||||||||
| OS: | Unspecified | ||||||||||
| See Also: | https://bugs.webkit.org/show_bug.cgi?id=149465 | ||||||||||
| Attachments: |
|
||||||||||
|
Description
Mark Hahnenberg
2014-06-26 14:48:40 PDT
Created attachment 233938 [details]
Patch
I filed bug 134364 to track fixing the issue with configurable attributes on the prototype. Comment on attachment 233938 [details]
Patch
r=me
Let's add a test that models the definProperty("responseType") thingy.
Comment on attachment 233938 [details] Patch Attachment 233938 [details] did not pass mac-wk2-ews (mac-wk2): Output: http://webkit-queues.appspot.com/results/4723205071699968 New failing tests: media/W3C/video/networkState/networkState_during_loadstart.html Created attachment 233941 [details]
Archive of layout-test-results from webkit-ews-10 for mac-mountainlion-wk2
The attached test failures were seen while running run-webkit-tests on the mac-wk2-ews.
Bot: webkit-ews-10 Port: mac-mountainlion-wk2 Platform: Mac OS X 10.8.5
Created attachment 233942 [details]
Patch
Comment on attachment 233942 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=233942&action=review I did not review this patch for correctness. I noticed a minor issue in the ChangeLog entry. > Source/WebCore/ChangeLog:8 > + No new tests. Please update the ChangeLog entry to reflect that this patch includes the test LayoutTests/js/dom/xhr-prototype-define-property.html Committed r170534: <http://trac.webkit.org/changeset/170534> |