Bug 134363

Summary: XHR should keep attributes on instance
Product: WebKit Reporter: Mark Hahnenberg <mhahnenberg>
Component: JavaScriptCoreAssignee: Mark Hahnenberg <mhahnenberg>
Status: RESOLVED FIXED    
Severity: Normal CC: buildbot, bunhere, cdumez, cgarcia, commit-queue, dbates, ggaren, gyuyoung.kim, oliver, rniwa, sergio
Priority: P2    
Version: 528+ (Nightly build)   
Hardware: Unspecified   
OS: Unspecified   
See Also: https://bugs.webkit.org/show_bug.cgi?id=149465
Attachments:
Description Flags
Patch
none
Archive of layout-test-results from webkit-ews-10 for mac-mountainlion-wk2
none
Patch sam: review+

Mark Hahnenberg
Reported 2014-06-26 14:48:40 PDT
Having them on the prototype broke some sites due to the fact that these DOM attributes are currently not configurable. Once we make them configurable, we can move XHR attributes back to the prototype.
Attachments
Patch (1.50 KB, patch)
2014-06-26 14:55 PDT, Mark Hahnenberg 		no flags
DetailsFormatted DiffDiff
Archive of layout-test-results from webkit-ews-10 for mac-mountainlion-wk2 (685.81 KB, application/zip)
2014-06-26 15:56 PDT, Build Bot 		no flags
Details
Patch (2.76 KB, patch)
2014-06-26 16:10 PDT, Mark Hahnenberg 		sam: review+
DetailsFormatted DiffDiff
Show Obsolete (1) View All Add attachment proposed patch, testcase, etc.
Mark Hahnenberg
Comment 1 2014-06-26 14:55:18 PDT
Created attachment 233938 [details] Patch
Mark Hahnenberg
Comment 2 2014-06-26 14:56:00 PDT
I filed bug 134364 to track fixing the issue with configurable attributes on the prototype.
Geoffrey Garen
Comment 3 2014-06-26 15:28:58 PDT
Comment on attachment 233938 [details] Patch r=me
Geoffrey Garen
Comment 4 2014-06-26 15:29:31 PDT
Let's add a test that models the definProperty("responseType") thingy.
Build Bot
Comment 5 2014-06-26 15:56:53 PDT
Comment on attachment 233938 [details] Patch Attachment 233938 [details] did not pass mac-wk2-ews (mac-wk2): Output: http://webkit-queues.appspot.com/results/4723205071699968 New failing tests: media/W3C/video/networkState/networkState_during_loadstart.html
Build Bot
Comment 6 2014-06-26 15:56:57 PDT
Created attachment 233941 [details] Archive of layout-test-results from webkit-ews-10 for mac-mountainlion-wk2 The attached test failures were seen while running run-webkit-tests on the mac-wk2-ews. Bot: webkit-ews-10 Port: mac-mountainlion-wk2 Platform: Mac OS X 10.8.5
Mark Hahnenberg
Comment 7 2014-06-26 16:10:14 PDT
Created attachment 233942 [details] Patch
Daniel Bates
Comment 8 2014-06-26 21:51:46 PDT
Comment on attachment 233942 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=233942&action=review I did not review this patch for correctness. I noticed a minor issue in the ChangeLog entry. > Source/WebCore/ChangeLog:8 > + No new tests. Please update the ChangeLog entry to reflect that this patch includes the test LayoutTests/js/dom/xhr-prototype-define-property.html
Mark Hahnenberg
Comment 9 2014-06-27 10:50:27 PDT
Committed r170534: <http://trac.webkit.org/changeset/170534>
Mark Hahnenberg
Comment 10 2014-06-27 10:50:39 PDT
<rdar://problem/17444323>
Note You need to log in before you can comment on or make changes to this bug.