Summary: | [iOS] no need to deactivate audio session | ||||||
---|---|---|---|---|---|---|---|
Product: | WebKit | Reporter: | Eric Carlson <eric.carlson> | ||||
Component: | Media | Assignee: | Eric Carlson <eric.carlson> | ||||
Status: | RESOLVED FIXED | ||||||
Severity: | Normal | CC: | bunhere, cdumez, commit-queue, glenn, gyuyoung.kim, jer.noble, philipj, sergio, webkit-bug-importer | ||||
Priority: | P2 | Keywords: | InRadar | ||||
Version: | 528+ (Nightly build) | ||||||
Hardware: | Unspecified | ||||||
OS: | Unspecified | ||||||
Attachments: |
|
Description
Eric Carlson
2014-06-26 10:37:46 PDT
Created attachment 233916 [details]
Proposed patch.
Comment on attachment 233916 [details] Proposed patch. View in context: https://bugs.webkit.org/attachment.cgi?id=233916&action=review r=me > Source/WebCore/ChangeLog:9 > + [iOS] no need to deactivate audio session > + https://bugs.webkit.org/show_bug.cgi?id=134350 > + > + Reviewed by NOBODY (OOPS!). > + > + * platform/audio/mac/MediaSessionManagerMac.cpp: > + (MediaSessionManager::updateSessionState): Never call setActive:false. nit: Why not? (Maybe: "Embedding WebView apps may want to enable the audio session outside of the WebView, and since the AudioSession is global to the app, disabling the audio session can interrupt that audio." Committed r170485: https://trac.webkit.org/r170485 |