Bug 134337

Summary:

HIDGamepad should use CFIndex when looping

Product:

WebKit

Reporter:

Dean Jackson <dino>

Component:

New Bugs

Assignee:

Dean Jackson <dino>

Status:

RESOLVED FIXED

Severity:

Normal

CC:

bunhere, cdumez, commit-queue, gyuyoung.kim, sergio

Priority:

Version:

528+ (Nightly build)

Hardware:

Unspecified

OS:

Unspecified

Attachments:

Description	Flags
Patch	mitz: review+
Patch	none

Description Dean Jackson 2014-06-25 22:42:57 PDT

HIDGamepad should use CFIndex when looping

Comment 1 Dean Jackson 2014-06-25 22:45:46 PDT

Created attachment 233884 [details]
Patch

Comment 2 mitz 2014-06-25 22:48:14 PDT

Comment on attachment 233884 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=233884&action=review

> Source/WebCore/platform/mac/HIDGamepad.cpp:79
> +    CFIndex count = CFArrayGetCount(elements);
> +    for (CFIndex i = 0; i < count; ++i) {

Our usual style for this is for (CFIndex i = 0, count = CFArrayGetCount(elements); i < count; ++i)

Comment 3 Dean Jackson 2014-06-25 22:55:43 PDT

Created attachment 233887 [details]
Patch

Comment 4 WebKit Commit Bot 2014-06-25 23:35:48 PDT

Comment on attachment 233887 [details]
Patch

Clearing flags on attachment: 233887

Committed r170469: <http://trac.webkit.org/changeset/170469>