Bug 134322
| Summary: | After r170428, offline assembler sometimes creates empty LLIntAssembly.h | ||
|---|---|---|---|
| Product: | WebKit | Reporter: | Michael Saboff <msaboff> |
| Component: | JavaScriptCore | Assignee: | Michael Saboff <msaboff> |
| Status: | RESOLVED INVALID | ||
| Severity: | Normal | CC: | peavo, simon.fraser |
| Priority: | P2 | ||
| Version: | 528+ (Nightly build) | ||
| Hardware: | All | ||
| OS: | All | ||
Michael Saboff
After r170428, the offline assembler will sometimes create an LLIntAssembly.h file with just the hash line:
// offlineasm input hash: cb3be4a5c6bc8076a46396599fba7c070d00cdf8 1fdc12e5c4851899db57a32e840ba77f46a9fa29 283b8172f1ff6e5e115dbe22d5c7494f289ea2da
| Attachments | ||
|---|---|---|
| Add attachment proposed patch, testcase, etc. |
peavo
This is just a guess, but could it be caused by an exception being thrown,
caused by for example the change in asm.rb?
--- Source/JavaScriptCore/offlineasm/asm.rb (revision 170426)
+++ Source/JavaScriptCore/offlineasm/asm.rb (working copy)
@@ -262,7 +262,7 @@ class Assembler
@codeOrigin = nil
@commentState = :many
when :many
- @outp.puts "// #{text}" if $enableCodeOriginComments
+ @outp.puts $commentPrefix + " #{text}" if $enableCodeOriginComments
else
raise
end
Michael Saboff
I can no longer get this to fail. When I filed, I performed the following steps:
svn up -r 170424
Tools/Scripts/build-webkit --debug
svn up -r 170431
Tools/Scripts/build-webkit --debug
The second build failed.
Today, those steps work fine. I tried multiple times, but can't reproduce.
We can file another bug if the problem reappears.