Bug 134318

Summary: [Win] Expose Cache Information to WinLauncher
Product: WebKit Reporter: Brent Fulgham <bfulgham>
Component: Tools / TestsAssignee: Brent Fulgham <bfulgham>
Status: RESOLVED FIXED    
Severity: Normal CC: bfulgham, bunhere, cdumez, commit-queue, dino, gyuyoung.kim, sergio, thorton
Priority: P2    
Version: 528+ (Nightly build)   
Hardware: PC   
OS: All   
Attachments:
Description Flags
Patch
none
Patch
none
Patch
none
Patch
none
Patch dino: review+

Brent Fulgham
Reported 2014-06-25 17:14:32 PDT
It would be useful to be able to see information about memory use and cache status of various objects in WebKit. This patch exposes the contents of our IWebCache and IWebCoreStatistics interfaces to the WinLauncher UI to make it easier to see this information.
Attachments
Patch (54.69 KB, patch)
2014-06-25 17:43 PDT, Brent Fulgham 		no flags
DetailsFormatted DiffDiff
Patch (38.76 KB, patch)
2014-06-26 09:15 PDT, Brent Fulgham 		no flags
DetailsFormatted DiffDiff
Patch (40.30 KB, patch)
2014-06-26 09:18 PDT, Brent Fulgham 		no flags
DetailsFormatted DiffDiff
Patch (54.69 KB, patch)
2014-06-26 09:21 PDT, Brent Fulgham 		no flags
DetailsFormatted DiffDiff
Patch (50.03 KB, patch)
2014-06-26 09:56 PDT, Brent Fulgham 		dino: review+
DetailsFormatted DiffDiff
Show Obsolete (4) View All Add attachment proposed patch, testcase, etc.
Brent Fulgham
Comment 1 2014-06-25 17:43:58 PDT
Created attachment 233858 [details] Patch
Brent Fulgham
Comment 2 2014-06-26 09:15:21 PDT
Created attachment 233906 [details] Patch
Brent Fulgham
Comment 3 2014-06-26 09:18:58 PDT
Created attachment 233907 [details] Patch
Brent Fulgham
Comment 4 2014-06-26 09:20:33 PDT
EWS bots are being difficult!
Brent Fulgham
Comment 5 2014-06-26 09:21:28 PDT
Created attachment 233908 [details] Patch
Brent Fulgham
Comment 6 2014-06-26 09:56:43 PDT
Created attachment 233910 [details] Patch
Brent Fulgham
Comment 7 2014-06-26 09:57:34 PDT
Looks like EOL-foo was confusing the bots. I landed a separate fix for the multiple EOL-styles in WinLauncher.h. Hopefully that will allow this patch to be processed successfully.
Dean Jackson
Comment 8 2014-06-26 10:09:07 PDT
Comment on attachment 233910 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=233910&action=review rs=me > Source/WebKit/win/WebCache.cpp:113 > + // Counts Nit: Missing period here and on the other new comments.
Brent Fulgham
Comment 9 2014-06-26 10:22:37 PDT
Committed r170483: <http://trac.webkit.org/changeset/170483>
Note You need to log in before you can comment on or make changes to this bug.