Bug 134317

Summary:

compositing/visible-rect/iframe-no-layers.html is broken and confusing

Product:

WebKit

Reporter:

Myles C. Maxfield <mmaxfield>

Component:

New Bugs

Assignee:

Myles C. Maxfield <mmaxfield>

Status:

RESOLVED FIXED

Severity:

Normal

CC:

bunhere, cdumez, commit-queue, dino, gyuyoung.kim, jonlee, sergio, simon.fraser, thorton

Priority:

Version:

528+ (Nightly build)

Hardware:

Unspecified

OS:

Unspecified

Attachments:

Description	Flags
Patch	simon.fraser: review+

Description Myles C. Maxfield 2014-06-25 16:42:00 PDT

compositing/visible-rect/iframe-no-layers.html is broken and confusing

Comment 1 Myles C. Maxfield 2014-06-25 17:18:03 PDT

Created attachment 233855 [details]
Patch

Comment 2 Simon Fraser (smfr) 2014-06-25 17:58:52 PDT

Comment on attachment 233855 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=233855&action=review

> LayoutTests/compositing/visible-rect/iframe-no-layers.html:25
> +        function testIsDone()

testIsDone is confusing because it's not done until called twice. Add a comment here saying that one call is from the subframe.

Comment 3 Myles C. Maxfield 2014-06-25 18:17:49 PDT

http://trac.webkit.org/changeset/170454