Bug 134317 - compositing/visible-rect/iframe-no-layers.html is broken and confusing
Summary: compositing/visible-rect/iframe-no-layers.html is broken and confusing
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: New Bugs (show other bugs)
Version: 528+ (Nightly build)
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Myles C. Maxfield
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2014-06-25 16:42 PDT by Myles C. Maxfield
Modified: 2014-06-25 18:17 PDT (History)
9 users (show)

See Also:

Attachments
Patch (6.78 KB, patch)
2014-06-25 17:18 PDT, Myles C. Maxfield 		simon.fraser: review+
Details | Formatted Diff | Diff
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Myles C. Maxfield 2014-06-25 16:42:00 PDT 
compositing/visible-rect/iframe-no-layers.html is broken and confusing
Comment 1 Myles C. Maxfield 2014-06-25 17:18:03 PDT 
Created attachment 233855 [details]
Patch
Comment 2 Simon Fraser (smfr) 2014-06-25 17:58:52 PDT 
Comment on attachment 233855 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=233855&action=review

> LayoutTests/compositing/visible-rect/iframe-no-layers.html:25
> +        function testIsDone()

testIsDone is confusing because it's not done until called twice. Add a comment here saying that one call is from the subframe.
Comment 3 Myles C. Maxfield 2014-06-25 18:17:49 PDT 
http://trac.webkit.org/changeset/170454