Bug 134315

Summary: Web process should become active when sent a message that requires a callback
Product: WebKit Reporter: mitz
Component: WebKit2Assignee: mitz
Status: RESOLVED FIXED    
Severity: Normal CC: buildbot, bunhere, cdumez, commit-queue, gyuyoung.kim, rniwa, sergio
Priority: P2    
Version: 528+ (Nightly build)   
Hardware: Unspecified   
OS: Unspecified   
Attachments:
Description Flags
Make callbacks hold on to an activity token
thorton: review+, buildbot: commit-queue-
Archive of layout-test-results from webkit-ews-15 for mac-mountainlion-wk2 none

mitz
Reported 2014-06-25 16:32:21 PDT
Web process should become active when sent a message that requires a callback
Attachments
Make callbacks hold on to an activity token (75.49 KB, patch)
2014-06-25 16:47 PDT, mitz 		thorton: review+
buildbot: commit-queue-
DetailsFormatted DiffDiff
Archive of layout-test-results from webkit-ews-15 for mac-mountainlion-wk2 (1009.06 KB, application/zip)
2014-06-25 17:43 PDT, Build Bot 		no flags
Details
View All Add attachment proposed patch, testcase, etc.
mitz
Comment 1 2014-06-25 16:47:09 PDT
Created attachment 233849 [details] Make callbacks hold on to an activity token
WebKit Commit Bot
Comment 2 2014-06-25 16:48:45 PDT
Attachment 233849 [details] did not pass style-queue: ERROR: Source/WebKit2/UIProcess/GenericCallback.h:193: Extra space before ( in function call [whitespace/parens] [4] ERROR: Source/WebKit2/UIProcess/ios/ProcessAssertionIOS.mm:60: Place brace on its own line for function definitions. [whitespace/braces] [4] Total errors found: 2 in 14 files If any of these errors are false positives, please file a bug against check-webkit-style.
Build Bot
Comment 3 2014-06-25 17:43:25 PDT
Comment on attachment 233849 [details] Make callbacks hold on to an activity token Attachment 233849 [details] did not pass mac-wk2-ews (mac-wk2): Output: http://webkit-queues.appspot.com/results/4657953244184576 New failing tests: http/tests/navigation/success200-goback.html http/tests/navigation/redirect302-goback.html http/tests/navigation/postredirect-goback1.html http/tests/navigation/post-goback-same-url.html http/tests/navigation/postredirect-reload.html http/tests/navigation/relativeanchor-goback.html http/tests/navigation/success200-reload.html http/tests/navigation/javascriptlink-goback.html http/tests/navigation/postredirect-basic.html http/tests/navigation/forward-and-cancel.html http/tests/navigation/post-goback2.html http/tests/navigation/timerredirect-goback.html http/tests/navigation/restore-form-state-https.html http/tests/navigation/anchor-goback.html http/tests/navigation/success200-frames-loadsame.html http/tests/navigation/relativeanchor-basic.html http/tests/navigation/postredirect-frames.html http/tests/navigation/metaredirect-goback.html http/tests/navigation/error404-goback.html http/tests/navigation/postredirect-goback2.html http/tests/navigation/success200-loadsame.html
Build Bot
Comment 4 2014-06-25 17:43:28 PDT
Created attachment 233857 [details] Archive of layout-test-results from webkit-ews-15 for mac-mountainlion-wk2 The attached test failures were seen while running run-webkit-tests on the mac-wk2-ews. Bot: webkit-ews-15 Port: mac-mountainlion-wk2 Platform: Mac OS X 10.8.5
mitz
Comment 5 2014-06-25 17:53:33 PDT
(In reply to comment #4) > Created an attachment (id=233857) [details] > Archive of layout-test-results from webkit-ews-15 for mac-mountainlion-wk2 > > The attached test failures were seen while running run-webkit-tests on the mac-wk2-ews. > Bot: webkit-ews-15 Port: mac-mountainlion-wk2 Platform: Mac OS X 10.8.5 This should be fixed with http://trac.webkit.org/r170452.
Note You need to log in before you can comment on or make changes to this bug.