Bug 134300 – [GTK] Expose getter and setter functions for attributes named type

• Component: Bindings
• Status: RESOLVED FIXED

[Carlos Garcia Campos]

We skip those because the getter conflicts with the get_type() function of all GObjects. We can use a different name for them. As a general rule we can use the last word of the class name, something like:

webkit_dom_blob_get_type() -> webkit_dom_blob_get_blob_type()
webkit_dom_event_get_type() -> webkit_dom_event_get_event_type()

That's consistent with other existing DOM methods like webkit_dom_xpath_result_get_result_type() or webkit_dom_css_value_get_css_value_type().

We would still need to add some exceptions, but they are not that much in the end.

[Carlos Garcia Campos]

Created attachment 233819 [details]
Patch

We should also expose the constants used by some of those new methods when bug #133983 is fixed.

[Carlos Garcia Campos]

Created attachment 233893 [details]
Updated patch

Updated to add the constants needed by some get_type methods to the public symbols list now that we support constants.

[Build Bot]

Comment on attachment 233893 [details]
Updated patch

Attachment 233893 [details] did not pass mac-wk2-ews (mac-wk2):
Output: http://webkit-queues.appspot.com/results/5827650274721792

New failing tests:
media/W3C/video/networkState/networkState_during_loadstart.html

[Build Bot]

Created attachment 233897 [details]
Archive of layout-test-results from webkit-ews-13 for mac-mountainlion-wk2

The attached test failures were seen while running run-webkit-tests on the mac-wk2-ews.
Bot: webkit-ews-13  Port: mac-mountainlion-wk2  Platform: Mac OS X 10.8.5

[Martin Robinson]

Comment on attachment 233893 [details]
Updated patch

View in context: https://bugs.webkit.org/attachment.cgi?id=233893&action=review

> Source/WebCore/bindings/scripts/CodeGeneratorGObject.pm:971
> +sub GetFunctionSigName {

Sig->Signature

> Source/WebCore/bindings/scripts/CodeGeneratorGObject.pm:1021
> +    my $functionSigName = GetFunctionSigName($interfaceName, $function);

Ditto.

[Carlos Garcia Campos]

Committed r170524: <http://trac.webkit.org/changeset/170524>