Bug 134289

Summary: Rearrange conditions to find invalid protocol in NavigatorContentUtils::verifyProtocolHandlerScheme()
Product: WebKit Reporter: Gyuyoung Kim <gyuyoung.kim>
Component: WebCore Misc.Assignee: Gyuyoung Kim <gyuyoung.kim>
Status: RESOLVED FIXED    
Severity: Normal CC: bunhere, cdumez, commit-queue, darin, gyuyoung.kim, sergio
Priority: P2    
Version: 528+ (Nightly build)   
Hardware: Unspecified   
OS: Unspecified   
Attachments:
Description Flags
Patch none

Gyuyoung Kim
Reported 2014-06-24 20:09:23 PDT
I think it would be good to do "early return" if there is invalid protocol.
Attachments
Patch (1.95 KB, patch)
2014-06-24 20:13 PDT, Gyuyoung Kim 		no flags
DetailsFormatted DiffDiff
View All Add attachment proposed patch, testcase, etc.
Gyuyoung Kim
Comment 1 2014-06-24 20:13:41 PDT
Created attachment 233780 [details] Patch
Gyuyoung Kim
Comment 2 2014-06-26 15:50:11 PDT
CC'ing Darin.
WebKit Commit Bot
Comment 3 2014-06-26 17:27:35 PDT
Comment on attachment 233780 [details] Patch Clearing flags on attachment: 233780 Committed r170511: <http://trac.webkit.org/changeset/170511>
WebKit Commit Bot
Comment 4 2014-06-26 17:27:41 PDT
All reviewed patches have been landed. Closing bug.
Note You need to log in before you can comment on or make changes to this bug.