Bug 134289 - Rearrange conditions to find invalid protocol in NavigatorContentUtils::verifyProtocolHandlerScheme()
Summary: Rearrange conditions to find invalid protocol in NavigatorContentUtils::verif...
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: WebCore Misc. (show other bugs)
Version: 528+ (Nightly build)
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Gyuyoung Kim
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2014-06-24 20:09 PDT by Gyuyoung Kim
Modified: 2014-06-26 17:27 PDT (History)
6 users (show)

See Also:

Attachments
Patch (1.95 KB, patch)
2014-06-24 20:13 PDT, Gyuyoung Kim 		no flags Details | Formatted Diff | Diff
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Gyuyoung Kim 2014-06-24 20:09:23 PDT 
I think it would be good to do "early return" if there is invalid protocol.
Comment 1 Gyuyoung Kim 2014-06-24 20:13:41 PDT 
Created attachment 233780 [details]
Patch
Comment 2 Gyuyoung Kim 2014-06-26 15:50:11 PDT 
CC'ing Darin.
Comment 3 WebKit Commit Bot 2014-06-26 17:27:35 PDT 
Comment on attachment 233780 [details]
Patch

Clearing flags on attachment: 233780

Committed r170511: <http://trac.webkit.org/changeset/170511>
Comment 4 WebKit Commit Bot 2014-06-26 17:27:41 PDT 
All reviewed patches have been landed.  Closing bug.