Bug 134257

Summary: [iOS]: WK2 Inspector Node Highlighting
Product: WebKit Reporter: Joseph Pecoraro <joepeck>
Component: WebKit2Assignee: Nobody <webkit-unassigned>
Status: RESOLVED FIXED    
Severity: Normal CC: benjamin, bunhere, cdumez, commit-queue, gyuyoung.kim, joepeck, sergio, simon.fraser, thorton, timothy
Priority: P2    
Version: 528+ (Nightly build)   
Hardware: All   
OS: All   
Attachments:
Description Flags
[PATCH] Proposed Fix
none
[PATCH] Proposed Fix
none
[PATCH] For Windows Symbol
none
[PATCH] With New Windows Symbol none

Description Joseph Pecoraro 2014-06-24 11:50:23 PDT 
Hovering nodes in the inspector is not highlighting them on the page. Inspector node highlighting needs to be hooked up.
Comment 1 Joseph Pecoraro 2014-06-24 13:15:17 PDT 
Created attachment 233732 [details]
[PATCH] Proposed Fix

I decided to do this in the UIProcess so we can keep the CAShapeLayer approach like iOS WK1. Tested iOS WK1 and WK2 and both behave as expected.
Comment 2 Joseph Pecoraro 2014-06-24 13:29:27 PDT 
Created attachment 233735 [details]
[PATCH] Proposed Fix

Rebaselined.
Comment 3 Joseph Pecoraro 2014-06-24 14:17:07 PDT 
Created attachment 233739 [details]
[PATCH] For Windows Symbol

For windows to get new symbol name.
Comment 4 Joseph Pecoraro 2014-06-24 14:57:19 PDT 
Created attachment 233744 [details]
[PATCH] With New Windows Symbol
Comment 5 WebKit Commit Bot 2014-06-24 16:50:38 PDT 
Comment on attachment 233744 [details]
[PATCH] With New Windows Symbol

Clearing flags on attachment: 233744

Committed r170406: <http://trac.webkit.org/changeset/170406>
Comment 6 WebKit Commit Bot 2014-06-24 16:50:43 PDT 
All reviewed patches have been landed.  Closing bug.