Bug 134243

Summary: Remove HarfBuzzShaper::setDrawRange()
Product: WebKit Reporter: Jaehun Lim <ljaehun.lim>
Component: WebCore Misc.Assignee: Jaehun Lim <ljaehun.lim>
Status: RESOLVED FIXED    
Severity: Normal CC: bunhere, cdumez, commit-queue, d-r, gyuyoung.kim, mpakulavelrutka, sergio, shiva.jm
Priority: P2    
Version: 528+ (Nightly build)   
Hardware: Unspecified   
OS: Unspecified   
Attachments:
Description Flags
Patch
none
Patch none

Jaehun Lim
Reported 2014-06-24 01:06:22 PDT
setDrawRange() is not used anywhere. Remove it. And m_fromIndex and m_toIndex are changed by only setDrawRange(). So, remove them too and use the default values instead of them.
Attachments
Patch (4.13 KB, patch)
2014-06-24 01:09 PDT, Jaehun Lim 		no flags
DetailsFormatted DiffDiff
Patch (4.14 KB, patch)
2014-06-30 00:10 PDT, Jaehun Lim 		no flags
DetailsFormatted DiffDiff
Show Obsolete (1) View All Add attachment proposed patch, testcase, etc.
Jaehun Lim
Comment 1 2014-06-24 01:09:51 PDT
Created attachment 233689 [details] Patch
Jaehun Lim
Comment 2 2014-06-26 03:24:36 PDT
setDrawRange() is not used anywhere after Skia has gone. And this patch can fix some breakages when EFL clean build.
Michal Pakula vel Rutka
Comment 3 2014-06-27 07:34:08 PDT
*** Bug 134247 has been marked as a duplicate of this bug. ***
Jaehun Lim
Comment 4 2014-06-30 00:10:41 PDT
Created attachment 234068 [details] Patch
Gyuyoung Kim
Comment 5 2014-06-30 00:39:56 PDT
Comment on attachment 234068 [details] Patch HarfBuzz is only used for EFL and GTK ports. Looks reasonable removing.
Shivakumar J M
Comment 6 2014-06-30 01:27:30 PDT
*** Bug 134382 has been marked as a duplicate of this bug. ***
WebKit Commit Bot
Comment 7 2014-06-30 01:32:42 PDT
Comment on attachment 234068 [details] Patch Clearing flags on attachment: 234068 Committed r170579: <http://trac.webkit.org/changeset/170579>
WebKit Commit Bot
Comment 8 2014-06-30 01:32:47 PDT
All reviewed patches have been landed. Closing bug.
Note You need to log in before you can comment on or make changes to this bug.