Bug 134241

Summary:

Caret positions in ligatures are not placed according to font files' specifications

Product:

WebKit

Reporter:

Myles C. Maxfield <mmaxfield>

Component:

New Bugs

Assignee:

Myles C. Maxfield <mmaxfield>

Status:

NEW

Severity:

Normal

CC:

buildbot, bunhere, cdumez, commit-queue, dino, gyuyoung.kim, jonlee, rniwa, sergio, simon.fraser, thorton, webkit-bug-importer

Priority:

Keywords:

InRadar

Version:

528+ (Nightly build)

Hardware:

Unspecified

OS:

Unspecified

Attachments:

Description	Flags
Needs tests	none
Patch	buildbot: commit-queue-
Archive of layout-test-results from webkit-ews-11 for mac-mountainlion-wk2	none

Myles C. Maxfield

Reported 2014-06-23 23:00:32 PDT

Use CTFontGetLigatureCaretPositions to determine where to place the caret in ligatures

Attachments
Needs tests (7.94 KB, patch) 2014-06-23 23:02 PDT, Myles C. Maxfield	no flags	Details Formatted Diff Diff
Patch (11.78 KB, patch) 2014-06-24 18:47 PDT, Myles C. Maxfield	buildbot: commit-queue-	Details Formatted Diff Diff
Archive of layout-test-results from webkit-ews-11 for mac-mountainlion-wk2 (621.01 KB, application/zip) 2014-06-24 21:21 PDT, Build Bot	no flags	Details
Show Obsolete (1) View All Add attachment proposed patch, testcase, etc.

Myles C. Maxfield

Comment 1 2014-06-23 23:02:54 PDT

Created attachment 233685 [details] Needs tests This patch potentially has devastating performance and memory characteristics. I need to investigate what the hit is.

Myles C. Maxfield

Comment 2 2014-06-23 23:05:55 PDT

The test case I've been using is <span style="font-family: HoeflerText-Regular; font-size: 400px;">filter</span>

Myles C. Maxfield

Comment 3 2014-06-23 23:08:31 PDT

Comment on attachment 233685 [details] Needs tests View in context: https://bugs.webkit.org/attachment.cgi?id=233685&action=review > Source/WebCore/platform/graphics/mac/ComplexTextController.cpp:560 > } else if (iterationStyle == ByWholeGlyphs) { On line 553 above there is a comment which is not accurate.

Myles C. Maxfield

Comment 4 2014-06-24 18:47:57 PDT

Created attachment 233774 [details] Patch

Myles C. Maxfield

Comment 5 2014-06-24 18:48:44 PDT

The characteristics I alluded to above still hold; I still need to do investigation. However, since I added a test, I thought I would still r? this patch so others might comment.

Build Bot

Comment 6 2014-06-24 21:20:59 PDT

Comment on attachment 233774 [details] Patch Attachment 233774 [details] did not pass mac-wk2-ews (mac-wk2): Output: http://webkit-queues.appspot.com/results/5288568771575808 New failing tests: media/W3C/video/networkState/networkState_during_loadstart.html

Build Bot

Comment 7 2014-06-24 21:21:03 PDT

Created attachment 233784 [details] Archive of layout-test-results from webkit-ews-11 for mac-mountainlion-wk2 The attached test failures were seen while running run-webkit-tests on the mac-wk2-ews. Bot: webkit-ews-11 Port: mac-mountainlion-wk2 Platform: Mac OS X 10.8.5

Myles C. Maxfield

Comment 8 2014-06-25 10:50:03 PDT

Failure seems to be unrelated

Myles C. Maxfield

Comment 9 2014-09-02 11:44:45 PDT

<rdar://problem/8477480>

Michael Catanzaro

Comment 10 2016-09-17 07:11:49 PDT

Comment on attachment 233774 [details] Patch Hi, Apologies that your patch was not reviewed in a timely manner. Since it's now quite old, I am removing it from the review request queue. Please consider rebasing it on trunk and resubmitting. To increase the chances of getting a review, consider using 'Tools/Scripts/webkit-patch upload --suggest-reviewers' to CC reviewers who might be interested in this bug.

Note You need to log in before you can comment on or make changes to this bug.