Summary: | [iOS][WK2] REGRESSION (r169324): Page jumps to top when you type into a text field | ||||||
---|---|---|---|---|---|---|---|
Product: | WebKit | Reporter: | Daniel Bates <dbates> | ||||
Component: | WebKit2 | Assignee: | Daniel Bates <dbates> | ||||
Status: | RESOLVED FIXED | ||||||
Severity: | Normal | CC: | benjamin, enrica, simon.fraser | ||||
Priority: | P2 | Keywords: | InRadar, Regression | ||||
Version: | 528+ (Nightly build) | ||||||
Hardware: | iPhone / iPad | ||||||
OS: | Unspecified | ||||||
Attachments: |
|
Description
Daniel Bates
2014-06-23 15:52:15 PDT
Created attachment 233645 [details]
Patch
I'm not an expert in our scrolling logic. I'm open to suggestions.
For completeness, you can observe this regression in a ToT iOS WebKit build as follows: 1. Visit <http://www.twitter.com> and click Sign in. 2. Tap on the Username field to focus it. 3. Tap the > arrow above the keyboard to move the focus to the Password field. 4. Type an arbitrary character, say 'a', into the Password field. Notice that the scroll view noticeably jumps to the top of the page. Compare this to the behavior in iOS 7.1.1 (11D201). Comment on attachment 233645 [details]
Patch
That makes sense, the VisibleContentRect updates definitely drives the scroll position.
Comment on attachment 233645 [details] Patch Clearing flags on attachment: 233645 Committed r170344: <http://trac.webkit.org/changeset/170344> All reviewed patches have been landed. Closing bug. |