Bug 134214

Summary: Don't use the WK prefix for internal C++ types
Product: WebKit Reporter: Anders Carlsson <andersca>
Component: New BugsAssignee: Anders Carlsson <andersca>
Status: RESOLVED FIXED    
Severity: Normal CC: commit-queue
Priority: P2    
Version: 528+ (Nightly build)   
Hardware: Unspecified   
OS: Unspecified   
Attachments:
Description Flags
Patch mitz: review+

Anders Carlsson
Reported 2014-06-23 14:26:07 PDT
Don't use the WK prefix for internal C++ types
Attachments
Patch (36.28 KB, patch)
2014-06-23 14:28 PDT, Anders Carlsson 		mitz: review+
DetailsFormatted DiffDiff
View All Add attachment proposed patch, testcase, etc.
Anders Carlsson
Comment 1 2014-06-23 14:28:45 PDT
Created attachment 233636 [details] Patch
mitz
Comment 2 2014-06-23 14:30:32 PDT
Comment on attachment 233636 [details] Patch 👍
WebKit Commit Bot
Comment 3 2014-06-23 14:31:03 PDT
Attachment 233636 [details] did not pass style-queue: ERROR: Source/WebKit2/Shared/AssistedNodeInformation.h:44: enum members should use InterCaps with an initial capital letter. [readability/enum_casing] [4] Total errors found: 1 in 11 files If any of these errors are false positives, please file a bug against check-webkit-style.
Anders Carlsson
Comment 4 2014-06-23 14:33:58 PDT
Committed r170321: <http://trac.webkit.org/changeset/170321>
Note You need to log in before you can comment on or make changes to this bug.