Summary: | [Cocoa] No way to grant storage quotas for web application cache | ||||||
---|---|---|---|---|---|---|---|
Product: | WebKit | Reporter: | mitz | ||||
Component: | WebKit2 | Assignee: | mitz | ||||
Status: | RESOLVED FIXED | ||||||
Severity: | Normal | CC: | commit-queue | ||||
Priority: | P2 | ||||||
Version: | 528+ (Nightly build) | ||||||
Hardware: | Unspecified | ||||||
OS: | Unspecified | ||||||
Attachments: |
|
Description
mitz
2014-06-23 14:03:47 PDT
Created attachment 233635 [details]
Add WKUIDelegatePrivate method for increasing quota
Attachment 233635 [details] did not pass style-queue:
ERROR: Source/WebKit2/WebProcess/WebPage/WebPage.cpp:2580: Tab found; better to use spaces [whitespace/tab] [1]
ERROR: Source/WebKit2/WebProcess/WebPage/WebPage.cpp:2580: Missing spaces around | [whitespace/operators] [3]
ERROR: Source/WebKit2/UIProcess/WebPageProxy.cpp:4467: More than one command on the same line [whitespace/newline] [4]
ERROR: Source/WebKit2/WebProcess/WebCoreSupport/WebChromeClient.cpp:52: Alphabetical sorting problem. [build/include_order] [4]
ERROR: Source/WebKit2/UIProcess/Cocoa/UIDelegate.h:66: Extra space before ( in function call [whitespace/parens] [4]
ERROR: Source/WebKit2/UIProcess/Cocoa/UIDelegate.mm:191: Place brace on its own line for function definitions. [whitespace/braces] [4]
ERROR: Source/WebKit2/UIProcess/Cocoa/UIDelegate.mm:197: Extra space before ( in function call [whitespace/parens] [4]
ERROR: Source/WebKit2/UIProcess/Cocoa/UIDelegate.mm:211: Place brace on its own line for function definitions. [whitespace/braces] [4]
ERROR: Source/WebKit2/UIProcess/API/APIUIClient.h:118: Extra space before ( in function call [whitespace/parens] [4]
Total errors found: 9 in 15 files
If any of these errors are false positives, please file a bug against check-webkit-style.
Comment on attachment 233635 [details] Add WKUIDelegatePrivate method for increasing quota View in context: https://bugs.webkit.org/attachment.cgi?id=233635&action=review > Source/WebKit2/WebProcess/WebPage/WebPage.cpp:2580 > + settings.setOfflineWebApplicationCacheEnabled(true /* FIMXE OOPS */|| store.getBoolValueForKey(WebPreferencesKey::offlineWebApplicationCacheEnabledKey())); OOPS! Fixed in <http://trac.webkit.org/r170320>. |