Bug 134213 - [Cocoa] No way to grant storage quotas for web application cache
Summary: [Cocoa] No way to grant storage quotas for web application cache
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: WebKit2 (show other bugs)
Version: 528+ (Nightly build)
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: mitz
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2014-06-23 14:03 PDT by mitz
Modified: 2014-06-23 14:33 PDT (History)
1 user (show)

See Also:

Attachments
Add WKUIDelegatePrivate method for increasing quota (22.01 KB, patch)
2014-06-23 14:25 PDT, mitz 		andersca: review+
Details | Formatted Diff | Diff
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description mitz 2014-06-23 14:03:47 PDT 
[Cocoa] No way to grant storage quotas for web application cache
Comment 1 mitz 2014-06-23 14:25:20 PDT 
Created attachment 233635 [details]
Add WKUIDelegatePrivate method for increasing quota
Comment 2 WebKit Commit Bot 2014-06-23 14:26:23 PDT 
Attachment 233635 [details] did not pass style-queue:


ERROR: Source/WebKit2/WebProcess/WebPage/WebPage.cpp:2580:  Tab found; better to use spaces  [whitespace/tab] [1]
ERROR: Source/WebKit2/WebProcess/WebPage/WebPage.cpp:2580:  Missing spaces around |  [whitespace/operators] [3]
ERROR: Source/WebKit2/UIProcess/WebPageProxy.cpp:4467:  More than one command on the same line  [whitespace/newline] [4]
ERROR: Source/WebKit2/WebProcess/WebCoreSupport/WebChromeClient.cpp:52:  Alphabetical sorting problem.  [build/include_order] [4]
ERROR: Source/WebKit2/UIProcess/Cocoa/UIDelegate.h:66:  Extra space before ( in function call  [whitespace/parens] [4]
ERROR: Source/WebKit2/UIProcess/Cocoa/UIDelegate.mm:191:  Place brace on its own line for function definitions.  [whitespace/braces] [4]
ERROR: Source/WebKit2/UIProcess/Cocoa/UIDelegate.mm:197:  Extra space before ( in function call  [whitespace/parens] [4]
ERROR: Source/WebKit2/UIProcess/Cocoa/UIDelegate.mm:211:  Place brace on its own line for function definitions.  [whitespace/braces] [4]
ERROR: Source/WebKit2/UIProcess/API/APIUIClient.h:118:  Extra space before ( in function call  [whitespace/parens] [4]
Total errors found: 9 in 15 files


If any of these errors are false positives, please file a bug against check-webkit-style.
Comment 3 Anders Carlsson 2014-06-23 14:27:26 PDT 
Comment on attachment 233635 [details]
Add WKUIDelegatePrivate method for increasing quota

View in context: https://bugs.webkit.org/attachment.cgi?id=233635&action=review

> Source/WebKit2/WebProcess/WebPage/WebPage.cpp:2580
> +    settings.setOfflineWebApplicationCacheEnabled(true /* FIMXE OOPS		 */|| store.getBoolValueForKey(WebPreferencesKey::offlineWebApplicationCacheEnabledKey()));

OOPS!
Comment 4 mitz 2014-06-23 14:33:19 PDT 
Fixed in <http://trac.webkit.org/r170320>.