Bug 134189

Summary: [wk2] Synchronously wait a short time for a layer tree update after bringing a web view in-window
Product: WebKit Reporter: Tim Horton <thorton>
Component: WebKit2Assignee: Tim Horton <thorton>
Status: RESOLVED FIXED    
Severity: Normal CC: andersca, benjamin, mitz, simon.fraser, webkit-bug-importer
Priority: P2 Keywords: InRadar
Version: 528+ (Nightly build)   
Hardware: Unspecified   
OS: Unspecified   
Bug Depends on:    
Bug Blocks: 134004    
Attachments:
Description Flags
patch simon.fraser: review+

Description Tim Horton 2014-06-23 02:01:55 PDT 
So that we don't flash white because of the unparented layer tree.

We can probably short-circuit this sometimes if we have view snapshots, but that is a future optimization.
Comment 1 Tim Horton 2014-06-23 02:48:15 PDT 
Created attachment 233589 [details]
patch
Comment 2 Tim Horton 2014-06-23 12:39:49 PDT 
This won't apply because it's on top of https://bugs.webkit.org/show_bug.cgi?id=134004
Comment 3 Simon Fraser (smfr) 2014-06-23 13:53:37 PDT 
Comment on attachment 233589 [details]
patch

View in context: https://bugs.webkit.org/attachment.cgi?id=233589&action=review

> Source/WebKit2/UIProcess/mac/RemoteLayerTreeDrawingAreaProxy.mm:327
> +    auto viewStateUpdateTimeout = std::chrono::milliseconds(500);

500 vs...

> Source/WebKit2/UIProcess/mac/TiledCoreAnimationDrawingAreaProxy.mm:132
> +    auto viewStateUpdateTimeout = std::chrono::milliseconds(250);

250?

> Source/WebKit2/WebProcess/WebPage/mac/RemoteLayerTreeDrawingArea.h:124
> +        static PassRefPtr<BackingStoreFlusher> create(FlushingContext);

Did you mean to pass by value?

> Source/WebKit2/WebProcess/WebPage/mac/RemoteLayerTreeDrawingArea.mm:320
> +    BackingStoreFlusher::FlushingContext flushingContext;

I can has constructor?
Comment 4 Tim Horton 2014-06-23 14:33:39 PDT 
http://trac.webkit.org/changeset/170319
Comment 5 Radar WebKit Bug Importer 2014-06-23 14:34:38 PDT 
<rdar://problem/17425232>