Bug 134183

Summary:

[iOS] Use WebGLLayer rather than PlatformLayer in GraphicsContext3D

Product:

WebKit

Reporter:

Dean Jackson <dino>

Component:

New Bugs

Assignee:

Dean Jackson <dino>

Status:

RESOLVED FIXED

Severity:

Normal

CC:

bfulgham, commit-queue, kondapallykalyan, roger_fong, simon.fraser, thorton

Priority:

Version:

528+ (Nightly build)

Hardware:

Unspecified

OS:

Unspecified

Attachments:

Description	Flags
Patch	sam: review+

Description Dean Jackson 2014-06-22 20:59:08 PDT

[iOS] Use WebGLLayer rather than PlatformLayer in GraphicsContext3D

Comment 1 Dean Jackson 2014-06-22 21:02:29 PDT

Created attachment 233583 [details]
Patch

Comment 2 Sam Weinig 2014-06-22 22:42:35 PDT

Comment on attachment 233583 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=233583&action=review

> Source/WebCore/ChangeLog:13
> +        * platform/graphics/GraphicsContext3D.h: Replace RefPtr<PlatformLayer>
> +        with RefPtr<WebGLLayer>.

RetainPtr, not RefPtr.

> Source/WebCore/platform/graphics/GraphicsContext3D.h:1010
>  #if PLATFORM(IOS)
>      PlatformGraphicsContext3D m_contextObj;
> -    RetainPtr<PlatformLayer> m_webGLLayer;
> +    RetainPtr<WebGLLayer> m_webGLLayer;
>  #elif PLATFORM(MAC)
>      CGLContextObj m_contextObj;
>      RetainPtr<WebGLLayer> m_webGLLayer;

Can this just be turned into PLATFORM(COCOA)?

Comment 3 Dean Jackson 2014-06-23 01:06:24 PDT

Committed r170285: <http://trac.webkit.org/changeset/170285>