Bug 134183

Summary: [iOS] Use WebGLLayer rather than PlatformLayer in GraphicsContext3D
Product: WebKit Reporter: Dean Jackson <dino>
Component: New BugsAssignee: Dean Jackson <dino>
Status: RESOLVED FIXED    
Severity: Normal CC: bfulgham, commit-queue, kondapallykalyan, roger_fong, simon.fraser, thorton
Priority: P2    
Version: 528+ (Nightly build)   
Hardware: Unspecified   
OS: Unspecified   
Attachments:
Description Flags
Patch sam: review+

Dean Jackson
Reported 2014-06-22 20:59:08 PDT
[iOS] Use WebGLLayer rather than PlatformLayer in GraphicsContext3D
Attachments
Patch (2.28 KB, patch)
2014-06-22 21:02 PDT, Dean Jackson 		sam: review+
DetailsFormatted DiffDiff
View All Add attachment proposed patch, testcase, etc.
Dean Jackson
Comment 1 2014-06-22 21:02:29 PDT
Created attachment 233583 [details] Patch
Sam Weinig
Comment 2 2014-06-22 22:42:35 PDT
Comment on attachment 233583 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=233583&action=review > Source/WebCore/ChangeLog:13 > + * platform/graphics/GraphicsContext3D.h: Replace RefPtr<PlatformLayer> > + with RefPtr<WebGLLayer>. RetainPtr, not RefPtr. > Source/WebCore/platform/graphics/GraphicsContext3D.h:1010 > #if PLATFORM(IOS) > PlatformGraphicsContext3D m_contextObj; > - RetainPtr<PlatformLayer> m_webGLLayer; > + RetainPtr<WebGLLayer> m_webGLLayer; > #elif PLATFORM(MAC) > CGLContextObj m_contextObj; > RetainPtr<WebGLLayer> m_webGLLayer; Can this just be turned into PLATFORM(COCOA)?
Dean Jackson
Comment 3 2014-06-23 01:06:24 PDT
Committed r170285: <http://trac.webkit.org/changeset/170285>
Note You need to log in before you can comment on or make changes to this bug.