Bug 134181

Summary: [iOS][wk2] Swiping back sometimes results in a missing (not blank) swipe snapshot
Product: WebKit Reporter: Tim Horton <thorton>
Component: WebKit2Assignee: Tim Horton <thorton>
Status: RESOLVED FIXED    
Severity: Normal CC: benjamin, simon.fraser, webkit-bug-importer
Priority: P2 Keywords: InRadar
Version: 528+ (Nightly build)   
Hardware: Unspecified   
OS: Unspecified   
Attachments:
Description Flags
patch benjamin: review+

Description Tim Horton 2014-06-22 18:14:12 PDT
In r170036, I made it so that setRenderTreeSize would remove the snapshot even if m_snapshotRemovalTargetRenderTreeSize wasn't set, so that we would still wait until the first relevant layer tree commit to remove the snapshot. However, this also removed the only guard that ensured that we only removed the snapshot after the swipe was complete; now, any layer tree commit that comes in *during* the swipe will cause the snapshot to be removed. Oops!

Let's make the old behavior more explicit.
Comment 1 Tim Horton 2014-06-22 18:17:13 PDT
Created attachment 233581 [details]
patch
Comment 2 Radar WebKit Bug Importer 2014-06-22 18:19:57 PDT
<rdar://problem/17413411>
Comment 3 Benjamin Poulain 2014-06-22 18:23:36 PDT
Comment on attachment 233581 [details]
patch

Thanks! :)
Comment 4 Tim Horton 2014-06-22 18:32:38 PDT
http://trac.webkit.org/changeset/170277