| Summary: | [Apple] WebGL layer may use GC3D after free with remote layer hosting | ||||||
|---|---|---|---|---|---|---|---|
| Product: | WebKit | Reporter: | Dean Jackson <dino> | ||||
| Component: | New Bugs | Assignee: | Dean Jackson <dino> | ||||
| Status: | RESOLVED FIXED | ||||||
| Severity: | Normal | CC: | commit-queue, kondapallykalyan, roger_fong | ||||
| Priority: | P2 | ||||||
| Version: | 528+ (Nightly build) | ||||||
| Hardware: | Unspecified | ||||||
| OS: | Unspecified | ||||||
| Attachments: |
|
||||||
|
Description
Dean Jackson
2014-06-22 16:33:17 PDT
Created attachment 233580 [details]
Patch
Comment on attachment 233580 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=233580&action=review > Source/WebCore/platform/graphics/mac/GraphicsContext3DMac.mm:335 > + [m_webGLLayer.get() setContext:nullptr]; no .get() required! > Source/WebCore/platform/graphics/mac/WebGLLayer.mm:45 > +@synthesize context=m_context; ObjC members don't usually have an 'm_' prefix, just '_'. (I see this predates your changes, though). (In reply to comment #3) > (From update of attachment 233580 [details]) > View in context: https://bugs.webkit.org/attachment.cgi?id=233580&action=review > > > Source/WebCore/platform/graphics/mac/GraphicsContext3DMac.mm:335 > > + [m_webGLLayer.get() setContext:nullptr]; > > no .get() required! I was wondering what the approved syntax is here. I wanted to just do .context = nullptr; > > > Source/WebCore/platform/graphics/mac/WebGLLayer.mm:45 > > +@synthesize context=m_context; > > ObjC members don't usually have an 'm_' prefix, just '_'. (I see this predates your changes, though). Yeah, I considered changing that. Since you complained, I'll do it :) Committed r170271: <http://trac.webkit.org/changeset/170271> |