Bug 134173

Summary: InlineTextBox's m_len can be an unsigned (rather than an unsigned short)
Product: WebKit Reporter: Myles C. Maxfield <mmaxfield>
Component: Layout and RenderingAssignee: Myles C. Maxfield <mmaxfield>
Status: RESOLVED FIXED    
Severity: Normal CC: commit-queue, dbates, esprehn+autocc, glenn, kling, kondapallykalyan, zalan
Priority: P2    
Version: 528+ (Nightly build)   
Hardware: Unspecified   
OS: Unspecified   
Attachments:
Description Flags
Patch
none
Patch dbates: review+

Description Myles C. Maxfield 2014-06-22 10:36:41 PDT 
Simple line layout alleviates the need for these memory savings.
Comment 1 Myles C. Maxfield 2014-06-23 19:45:37 PDT 
Created attachment 233669 [details]
Patch
Comment 2 Myles C. Maxfield 2014-06-23 19:46:24 PDT 
Comment on attachment 233669 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=233669&action=review

> Source/WebCore/ChangeLog:8
> +        After Zalan's talks with Antti, it seems that the simple line layout code

Whoops. Looks like this was Kling.
Comment 3 Myles C. Maxfield 2014-06-23 19:46:58 PDT 
Created attachment 233670 [details]
Patch
Comment 4 Daniel Bates 2014-06-24 12:53:53 PDT 
Comment on attachment 233670 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=233670&action=review

OK

> Source/WebCore/rendering/InlineTextBox.h:38
> +const unsigned cNoTruncation = UINT_MAX;
> +const unsigned cFullTruncation = UINT_MAX - 1;

We should take this opportunity to substitute the C++ idiom of std::numeric_limits<unsigned>::max() for UINT_MAX in these lines.
Comment 5 Myles C. Maxfield 2014-06-24 18:20:16 PDT 
http://trac.webkit.org/changeset/170413