Bug 134167

Summary:

[Bindings] Properties with custom getters or setters should be on the prototypes

Product:

WebKit

Reporter:

Sam Weinig <sam>

Component:

New Bugs

Assignee:

Sam Weinig <sam>

Status:

RESOLVED FIXED

Severity:

Normal

CC:

buildbot, cdumez, cgarcia, commit-queue, rniwa

Priority:

Version:

528+ (Nightly build)

Hardware:

Unspecified

OS:

Unspecified

Attachments:

Description	Flags
Patch	buildbot: commit-queue-
Archive of layout-test-results from webkit-ews-05 for mac-mountainlion	none
Archive of layout-test-results from webkit-ews-04 for mac-mountainlion	none
Archive of layout-test-results from webkit-ews-14 for mac-mountainlion-wk2	none

Sam Weinig

Reported 2014-06-21 17:01:25 PDT

[Bindings] Properties with custom getters or setters should be on the prototypee

Attachments
Patch (15.18 KB, patch) 2014-06-21 17:05 PDT, Sam Weinig	buildbot: commit-queue-	Details Formatted Diff Diff
Archive of layout-test-results from webkit-ews-05 for mac-mountainlion (527.65 KB, application/zip) 2014-06-21 18:42 PDT, Build Bot	no flags	Details
Archive of layout-test-results from webkit-ews-04 for mac-mountainlion (526.93 KB, application/zip) 2014-06-21 19:42 PDT, Build Bot	no flags	Details
Archive of layout-test-results from webkit-ews-14 for mac-mountainlion-wk2 (569.30 KB, application/zip) 2014-06-22 01:50 PDT, Build Bot	no flags	Details
Show Obsolete (1) View All Add attachment proposed patch, testcase, etc.

Sam Weinig

Comment 1 2014-06-21 17:05:38 PDT

Created attachment 233551 [details] Patch

Build Bot

Comment 2 2014-06-21 18:42:48 PDT

Comment on attachment 233551 [details] Patch Attachment 233551 [details] did not pass mac-ews (mac): Output: http://webkit-queues.appspot.com/results/4883939390914560 New failing tests: http/tests/security/xss-DENIED-assign-location-href-javascript.html http/tests/security/cross-frame-access-enumeration.html

Build Bot

Comment 3 2014-06-21 18:42:51 PDT

Created attachment 233552 [details] Archive of layout-test-results from webkit-ews-05 for mac-mountainlion The attached test failures were seen while running run-webkit-tests on the mac-ews. Bot: webkit-ews-05 Port: mac-mountainlion Platform: Mac OS X 10.8.5

Build Bot

Comment 4 2014-06-21 19:42:06 PDT

Comment on attachment 233551 [details] Patch Attachment 233551 [details] did not pass mac-ews (mac): Output: http://webkit-queues.appspot.com/results/6221067911692288 New failing tests: http/tests/security/xss-DENIED-assign-location-href-javascript.html http/tests/security/cross-frame-access-enumeration.html

Build Bot

Comment 5 2014-06-21 19:42:09 PDT

Created attachment 233553 [details] Archive of layout-test-results from webkit-ews-04 for mac-mountainlion The attached test failures were seen while running run-webkit-tests on the mac-ews. Bot: webkit-ews-04 Port: mac-mountainlion Platform: Mac OS X 10.8.5

Build Bot

Comment 6 2014-06-22 01:50:39 PDT

Comment on attachment 233551 [details] Patch Attachment 233551 [details] did not pass mac-wk2-ews (mac-wk2): Output: http://webkit-queues.appspot.com/results/6247378881347584 New failing tests: http/tests/security/xss-DENIED-assign-location-href-javascript.html

Build Bot

Comment 7 2014-06-22 01:50:43 PDT

Created attachment 233562 [details] Archive of layout-test-results from webkit-ews-14 for mac-mountainlion-wk2 The attached test failures were seen while running run-webkit-tests on the mac-wk2-ews. Bot: webkit-ews-14 Port: mac-mountainlion-wk2 Platform: Mac OS X 10.8.5

Sam Weinig

Comment 8 2017-05-09 15:57:00 PDT

This was done long ago.

Note You need to log in before you can comment on or make changes to this bug.