| Summary: | Begin work on decoding form data | ||||||
|---|---|---|---|---|---|---|---|
| Product: | WebKit | Reporter: | Anders Carlsson <andersca> | ||||
| Component: | New Bugs | Assignee: | Anders Carlsson <andersca> | ||||
| Status: | RESOLVED FIXED | ||||||
| Severity: | Normal | CC: | commit-queue | ||||
| Priority: | P2 | ||||||
| Version: | 528+ (Nightly build) | ||||||
| Hardware: | Unspecified | ||||||
| OS: | Unspecified | ||||||
| Attachments: |
|
||||||
|
Description
Anders Carlsson
2014-06-21 13:38:22 PDT
Created attachment 233545 [details]
Patch
Attachment 233545 [details] did not pass style-queue:
ERROR: Source/WebKit2/UIProcess/mac/LegacySessionStateCoding.cpp:314: This { should be at the end of the previous line [whitespace/braces] [4]
Total errors found: 1 in 2 files
If any of these errors are false positives, please file a bug against check-webkit-style.
Comment on attachment 233545 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=233545&action=review > Source/WebKit2/UIProcess/mac/LegacySessionStateCoding.cpp:316 > + uint32_t underlyingEnumValue; > + *this >> underlyingEnumValue; Can this use std::underlying_type<>? Committed r170252: <http://trac.webkit.org/changeset/170252> (In reply to comment #3) > (From update of attachment 233545 [details]) > View in context: https://bugs.webkit.org/attachment.cgi?id=233545&action=review > > > Source/WebKit2/UIProcess/mac/LegacySessionStateCoding.cpp:316 > > + uint32_t underlyingEnumValue; > > + *this >> underlyingEnumValue; > > Can this use std::underlying_type<>? No, it needs to always use uint32_t. |