Bug 134156

Summary:

Transition layer offsets from LayoutPoint to LayoutSize.

Product:

WebKit

Reporter:

zalan <zalan>

Component:

Layout and Rendering

Assignee:

zalan <zalan>

Status:

RESOLVED FIXED

Severity:

Normal

CC:

commit-queue, esprehn+autocc, glenn, kondapallykalyan, simon.fraser, WebkitBugTracker

Priority:

Version:

528+ (Nightly build)

Hardware:

Unspecified

OS:

Unspecified

Bug Depends on:

Bug Blocks:

134168

Attachments:

Description	Flags
Patch	none
Patch	none

Description zalan 2014-06-21 09:05:42 PDT

Few RenderLayer functions use LayoutPoint to represent offset values. Use LayoutSize instead.

Comment 1 zalan 2014-06-21 09:16:02 PDT

Created attachment 233535 [details]
Patch

Comment 2 Simon Fraser (smfr) 2014-06-22 11:14:18 PDT

Comment on attachment 233535 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=233535&action=review

> Source/WebCore/platform/graphics/LayoutSize.h:195
> +inline FloatSize roundedForPainting(const LayoutSize& size, float pixelSnappingFactor)

but...but...how can you snap a size without knowing the location?

Comment 3 zalan 2014-06-22 15:35:52 PDT

(In reply to comment #2)
> (From update of attachment 233535 [details])
> View in context: https://bugs.webkit.org/attachment.cgi?id=233535&action=review
> 
> > Source/WebCore/platform/graphics/LayoutSize.h:195
> > +inline FloatSize roundedForPainting(const LayoutSize& size, float pixelSnappingFactor)
> 
> but...but...how can you snap a size without knowing the location?
It's magic! but yea, I should undo this.

Comment 4 zalan 2014-06-22 16:38:49 PDT

Created attachment 233579 [details]
Patch

Comment 5 WebKit Commit Bot 2014-06-22 17:34:56 PDT

Comment on attachment 233579 [details]
Patch

Clearing flags on attachment: 233579

Committed r170273: <http://trac.webkit.org/changeset/170273>

Comment 6 WebKit Commit Bot 2014-06-22 17:35:00 PDT

All reviewed patches have been landed.  Closing bug.