Bug 134119

Summary:

Add copy/move constructors and assignment operators to WTF::Optional

Product:

WebKit

Reporter:

Anders Carlsson <andersca>

Component:

New Bugs

Assignee:

Anders Carlsson <andersca>

Status:

RESOLVED FIXED

Severity:

Normal

CC:

benjamin, cmarcelo, commit-queue

Priority:

Version:

528+ (Nightly build)

Hardware:

Unspecified

OS:

Unspecified

Attachments:

Description	Flags
Patch	kling: review+

Description Anders Carlsson 2014-06-20 13:49:56 PDT

Add copy/move constructors and assignment operators to WTF::Optional

Comment 1 Anders Carlsson 2014-06-20 13:50:22 PDT

Created attachment 233449 [details]
Patch

Comment 2 Andreas Kling 2014-06-20 13:54:26 PDT

Comment on attachment 233449 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=233449&action=review

r=me with a bug fix:

> Source/WTF/wtf/Optional.h:137
> +        new (NotNull, std::addressof(m_value)) T(std::forward<U>(u));
> +        return *this;

Missing "m_isEngaged = true;" here.

Comment 3 Anders Carlsson 2014-06-20 13:55:30 PDT

Committed r170202: <http://trac.webkit.org/changeset/170202>