Summary: | REGRESSION(r170163): It made everything crash on EFL | ||||||
---|---|---|---|---|---|---|---|
Product: | WebKit | Reporter: | Zsolt Borbely <zsborbely.u-szeged> | ||||
Component: | WebKit EFL | Assignee: | Gyuyoung Kim <gyuyoung.kim> | ||||
Status: | RESOLVED FIXED | ||||||
Severity: | Critical | CC: | gyuyoung.kim, gyuyoung.kim, koivisto, lucas.de.marchi, ossy, simon.fraser | ||||
Priority: | P1 | ||||||
Version: | 528+ (Nightly build) | ||||||
Hardware: | Unspecified | ||||||
OS: | Unspecified | ||||||
Bug Depends on: | |||||||
Bug Blocks: | 134073 | ||||||
Attachments: |
|
Description
Zsolt Borbely
2014-06-20 01:00:55 PDT
AFAIK, m_mainFrame is null in WebPage::didCompletePageTransition() since r170163. So, if we simply add a null checking code as below, it looks EFL port is fine. However, we need to investigate r170163 further to sync with EFL port. void WebPage::didCompletePageTransition() { #if USE(TILED_BACKING_STORE) if (m_mainFrame && m_mainFrame->coreFrame()->view()->delegatesScrolling()) // Wait until the UI process sent us the visible rect it wants rendered. send(Messages::WebPageProxy::PageTransitionViewportReady()); else #endif m_drawingArea->setLayerTreeStateIsFrozen(false); } It seems not only perf tests, but layout tests crash too - http://build.webkit.org/builders/EFL%20Linux%2064-bit%20Release%20WK2/builds/15217 Created attachment 233508 [details]
Patch
Committed r170279: <http://trac.webkit.org/changeset/170279> Comment on attachment 233508 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=233508&action=review > Source/WebKit2/WebProcess/WebPage/WebPage.cpp:2268 > + // m_mainFrame can be null since r170163. Comments like this are not useful. (In reply to comment #5) > (From update of attachment 233508 [details]) > View in context: https://bugs.webkit.org/attachment.cgi?id=233508&action=review > > > Source/WebKit2/WebProcess/WebPage/WebPage.cpp:2268 > > + // m_mainFrame can be null since r170163. > > Comments like this are not useful. I see. I will not use similar comment in next time. Do you want to remove it now ? |