Bug 134096

Summary: [EFL] Remove the WebKit1 EFL code
Product: WebKit Reporter: Ryuan Choi <ryuan.choi>
Component: WebKit EFLAssignee: Ryuan Choi <ryuan.choi>
Status: RESOLVED FIXED    
Severity: Normal CC: bunhere, cdumez, commit-queue, gyuyoung.kim, lucas.de.marchi, ossy, rakuco, sergio
Priority: P2    
Version: 528+ (Nightly build)   
Hardware: Unspecified   
OS: Unspecified   
Bug Depends on:    
Bug Blocks: 134087    
Attachments:
Description Flags
Patch
gyuyoung.kim: review+
Patch none

Description Ryuan Choi 2014-06-20 00:14:14 PDT
rm -rf Source/WebKit/efl
Comment 1 Ryuan Choi 2014-06-20 01:34:01 PDT
Created attachment 233412 [details]
Patch
Comment 2 Gyuyoung Kim 2014-06-20 01:37:07 PDT
Comment on attachment 233412 [details]
Patch

rs=me
Comment 3 Ryuan Choi 2014-06-20 02:02:55 PDT
Created attachment 233416 [details]
Patch

Added one missing file
Comment 4 WebKit Commit Bot 2014-06-20 14:24:11 PDT
Comment on attachment 233416 [details]
Patch

Rejecting attachment 233416 [details] from commit-queue.

Failed to run "['/Volumes/Data/EWS/WebKit/Tools/Scripts/webkit-patch', '--status-host=webkit-queues.appspot.com', '--bot-id=webkit-cq-03', 'validate-changelog', '--check-oops', '--non-interactive', 233416, '--port=mac']" exit_code: 1 cwd: /Volumes/Data/EWS/WebKit

Last 500 characters of output:
 = self._filesystem.open_text_file_for_reading(self.path)
  File "/Volumes/Data/EWS/WebKit/Tools/Scripts/webkitpy/common/system/filesystem.py", line 204, in open_text_file_for_reading
    return codecs.open(path, 'r', 'utf8', errors)
  File "/System/Library/Frameworks/Python.framework/Versions/2.7/lib/python2.7/codecs.py", line 881, in open
    file = __builtin__.open(filename, mode, buffering)
IOError: [Errno 2] No such file or directory: u'/Volumes/Data/EWS/WebKit/Source/WebKit/efl/ChangeLog'

Full output: http://webkit-queues.appspot.com/results/6170918799802368
Comment 5 Ryuan Choi 2014-06-20 15:27:26 PDT
(In reply to comment #4)
> (From update of attachment 233416 [details])
> Rejecting attachment 233416 [details] from commit-queue.
> 
> Failed to run "['/Volumes/Data/EWS/WebKit/Tools/Scripts/webkit-patch', '--status-host=webkit-queues.appspot.com', '--bot-id=webkit-cq-03', 'validate-changelog', '--check-oops', '--non-interactive', 233416, '--port=mac']" exit_code: 1 cwd: /Volumes/Data/EWS/WebKit
> 
> Last 500 characters of output:
>  = self._filesystem.open_text_file_for_reading(self.path)
>   File "/Volumes/Data/EWS/WebKit/Tools/Scripts/webkitpy/common/system/filesystem.py", line 204, in open_text_file_for_reading
>     return codecs.open(path, 'r', 'utf8', errors)
>   File "/System/Library/Frameworks/Python.framework/Versions/2.7/lib/python2.7/codecs.py", line 881, in open
>     file = __builtin__.open(filename, mode, buffering)
> IOError: [Errno 2] No such file or directory: u'/Volumes/Data/EWS/WebKit/Source/WebKit/efl/ChangeLog'
> 
> Full output: http://webkit-queues.appspot.com/results/6170918799802368

Hmm, it looks that modified_changelogs() in checkout.py does not consider whether changelog is deleted or not.

I am not sure how I can land this before fixing Tools.

Below is the log when I used direct-land. ( ./Tools/Scripts/webkit-patch land-attachment 233416 [details] )

Can't open /home/ryuan/workspace/project/webkit/efl-webkit/Source/WebKit/efl/ChangeLog at /home/ryuan/workspace/project/webkit/efl-webkit/Tools/Scripts/commit-log-editor line 221.
Failed to run "[u'/home/ryuan/workspace/project/webkit/efl-webkit/Tools/Scripts/commit-log-editor', '--print-log', u'/home/ryuan/workspace/project/webkit/efl-webkit/Source/WebKit/ChangeLog', u'/home/ryuan/workspace/project/webkit/efl-webkit/Source/WebKit/efl/ChangeLog']" exit_code: 2
Failed to run "[u'/home/ryuan/workspace/project/webkit/efl-webkit/Tools/Scripts/commit-log-editor', '--print-log', u'/home/ryuan/workspace/project/webkit/efl-webkit/Source/WebKit/ChangeLog', u'/home/ryuan/workspace/project/webkit/efl-webkit/Source/WebKit/efl/ChangeLog']" exit_code: 2
Comment 6 Csaba Osztrogon√°c 2014-06-23 06:35:02 PDT
Landed in https://trac.webkit.org/changeset/170289 manually, git svn dcommit 
is our friends when webkit-patch land can't handle something. ;)
Comment 7 Ryuan Choi 2014-06-23 17:11:44 PDT
(In reply to comment #6)
> Landed in https://trac.webkit.org/changeset/170289 manually, git svn dcommit 
> is our friends when webkit-patch land can't handle something. ;)

Thanks. :)