Bug 134093

Summary: [EFL][CMAKE] Disable WebKit1 build as a default
Product: WebKit Reporter: Ryuan Choi <ryuan.choi>
Component: WebKit EFLAssignee: Ryuan Choi <ryuan.choi>
Status: RESOLVED FIXED    
Severity: Normal CC: bunhere, commit-queue, gyuyoung.kim, lucas.de.marchi, rakuco, sergio
Priority: P2    
Version: 528+ (Nightly build)   
Hardware: Unspecified   
OS: Unspecified   
Bug Depends on:    
Bug Blocks: 134087    
Attachments:
Description Flags
Patch none

Description Ryuan Choi 2014-06-19 23:15:42 PDT
SSIA
Comment 1 Ryuan Choi 2014-06-19 23:20:09 PDT
Created attachment 233408 [details]
Patch
Comment 2 Gyuyoung Kim 2014-06-19 23:36:21 PDT
Comment on attachment 233408 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=233408&action=review

r=me except for my questions.

> Source/cmake/OptionsEfl.cmake:8
> +set(ENABLE_WEBKIT OFF)

Should we keep this flag ?

> Tools/CMakeLists.txt:10
>      add_subdirectory(DumpRenderTree/TestNetscapePlugIn)

ditto
Comment 3 Ryuan Choi 2014-06-19 23:52:35 PDT
Comment on attachment 233408 [details]
Patch

Clearing flags on attachment: 233408

Committed r170175: <http://trac.webkit.org/changeset/170175>
Comment 4 Ryuan Choi 2014-06-19 23:52:44 PDT
All reviewed patches have been landed.  Closing bug.