Bug 134085

Summary: [iOS WebKit2] Make -webkit-overflow-scrolling:touch work in iframes (breaks MSWord previews)
Product: WebKit Reporter: Simon Fraser (smfr) <simon.fraser>
Component: New BugsAssignee: Simon Fraser (smfr) <simon.fraser>
Status: RESOLVED FIXED    
Severity: Normal CC: andersca, cmarcelo, commit-queue, jamesr, luiz, sam, simon.fraser, thorton, tonikitoo
Priority: P2    
Version: 528+ (Nightly build)   
Hardware: Unspecified   
OS: Unspecified   
Attachments:
Description Flags
Patch
none
Patch thorton: review+

Simon Fraser (smfr)
Reported 2014-06-19 17:53:32 PDT
[iOS WebKit2] Make -webkit-overflow-scrolling:touch work in iframes (breaks MSWord previews)
Attachments
Patch (67.75 KB, patch)
2014-06-19 19:26 PDT, Simon Fraser (smfr) 		no flags
DetailsFormatted DiffDiff
Patch (31.56 KB, patch)
2014-06-20 11:14 PDT, Simon Fraser (smfr) 		thorton: review+
DetailsFormatted DiffDiff
Show Obsolete (1) View All Add attachment proposed patch, testcase, etc.
Simon Fraser (smfr)
Comment 1 2014-06-19 19:26:08 PDT
Created attachment 233401 [details] Patch
Simon Fraser (smfr)
Comment 2 2014-06-20 11:14:06 PDT
Created attachment 233435 [details] Patch
Tim Horton
Comment 3 2014-06-20 11:31:00 PDT
Comment on attachment 233435 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=233435&action=review > Source/WebCore/page/scrolling/ScrollingStateTree.cpp:109 > + switch (nodeType) { this looks ripe for moving into another function, and factoring the appendChild out, and just cleaning up in general > Source/WebCore/page/scrolling/ScrollingStateTree.h:85 > + enum SubframeNodeRemoval { enum class? and drop the "SubframeNodes" suffix? SubframeNodeRemoval::Delete, SubframeNodeRemoval::Orphan, etc.
Simon Fraser (smfr)
Comment 4 2014-06-20 12:22:21 PDT
https://trac.webkit.org/r170198
Note You need to log in before you can comment on or make changes to this bug.