| Summary: | [iOS WebKit2] Make -webkit-overflow-scrolling:touch work in iframes (breaks MSWord previews) | ||||||||
|---|---|---|---|---|---|---|---|---|---|
| Product: | WebKit | Reporter: | Simon Fraser (smfr) <simon.fraser> | ||||||
| Component: | New Bugs | Assignee: | Simon Fraser (smfr) <simon.fraser> | ||||||
| Status: | RESOLVED FIXED | ||||||||
| Severity: | Normal | CC: | andersca, cmarcelo, commit-queue, jamesr, luiz, sam, simon.fraser, thorton, tonikitoo | ||||||
| Priority: | P2 | ||||||||
| Version: | 528+ (Nightly build) | ||||||||
| Hardware: | Unspecified | ||||||||
| OS: | Unspecified | ||||||||
| Attachments: |
|
||||||||
|
Description
Simon Fraser (smfr)
2014-06-19 17:53:32 PDT
Created attachment 233401 [details]
Patch
Created attachment 233435 [details]
Patch
Comment on attachment 233435 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=233435&action=review > Source/WebCore/page/scrolling/ScrollingStateTree.cpp:109 > + switch (nodeType) { this looks ripe for moving into another function, and factoring the appendChild out, and just cleaning up in general > Source/WebCore/page/scrolling/ScrollingStateTree.h:85 > + enum SubframeNodeRemoval { enum class? and drop the "SubframeNodes" suffix? SubframeNodeRemoval::Delete, SubframeNodeRemoval::Orphan, etc. |