Bug 134081

Summary: Enable synchronous willSendRequest on iOS
Product: WebKit Reporter: Pratik Solanki <psolanki>
Component: New BugsAssignee: Pratik Solanki <psolanki>
Status: RESOLVED FIXED    
Severity: Normal CC: buildbot, commit-queue, kling, psolanki, rniwa
Priority: P2 Keywords: InRadar
Version: 528+ (Nightly build)   
Hardware: Unspecified   
OS: Unspecified   
Attachments:
Description Flags
Patch
kling: review+, buildbot: commit-queue-
Archive of layout-test-results from webkit-ews-12 for mac-mountainlion-wk2 none

Pratik Solanki
Reported 2014-06-19 16:59:37 PDT
Enable synchronous willSendRequest on iOS
Attachments
Patch (2.57 KB, patch)
2014-06-19 17:11 PDT, Pratik Solanki 		kling: review+
buildbot: commit-queue-
DetailsFormatted DiffDiff
Archive of layout-test-results from webkit-ews-12 for mac-mountainlion-wk2 (839.82 KB, application/zip)
2014-06-19 23:01 PDT, Build Bot 		no flags
Details
View All Add attachment proposed patch, testcase, etc.
Pratik Solanki
Comment 1 2014-06-19 17:11:28 PDT
Created attachment 233393 [details] Patch
Andreas Kling
Comment 2 2014-06-19 17:16:52 PDT
Comment on attachment 233393 [details] Patch All right!
Build Bot
Comment 3 2014-06-19 23:01:43 PDT
Comment on attachment 233393 [details] Patch Attachment 233393 [details] did not pass mac-wk2-ews (mac-wk2): Output: http://webkit-queues.appspot.com/results/4575687415431168 New failing tests: compositing/absolute-position-changed-in-composited-layer.html
Build Bot
Comment 4 2014-06-19 23:01:46 PDT
Created attachment 233406 [details] Archive of layout-test-results from webkit-ews-12 for mac-mountainlion-wk2 The attached test failures were seen while running run-webkit-tests on the mac-wk2-ews. Bot: webkit-ews-12 Port: mac-mountainlion-wk2 Platform: Mac OS X 10.8.5
Pratik Solanki
Comment 5 2014-06-20 09:37:24 PDT
<rdar://problem/17350927>
Pratik Solanki
Comment 6 2014-06-20 09:38:24 PDT
(In reply to comment #3) > (From update of attachment 233393 [details]) > Attachment 233393 [details] did not pass mac-wk2-ews (mac-wk2): > Output: http://webkit-queues.appspot.com/results/4575687415431168 > > New failing tests: > compositing/absolute-position-changed-in-composited-layer.html The patch doesn't touch any Mac code so this failure can't be due to this code change. I'll land manually.
Pratik Solanki
Comment 7 2014-06-20 10:31:42 PDT
Committed r170190: <http://trac.webkit.org/changeset/170190>
Darin Adler
Comment 8 2014-06-20 12:13:27 PDT
Comment on attachment 233393 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=233393&action=review > Source/WebCore/platform/network/cf/ResourceHandleCFURLConnectionDelegateWithOperationQueue.cpp:69 > + CFURLRequestSetShouldStartSynchronously(request, 1); I would have expected true or TRUE here instead of 1.
Note You need to log in before you can comment on or make changes to this bug.