| Summary: | Enable synchronous willSendRequest on iOS | ||||||||
|---|---|---|---|---|---|---|---|---|---|
| Product: | WebKit | Reporter: | Pratik Solanki <psolanki> | ||||||
| Component: | New Bugs | Assignee: | Pratik Solanki <psolanki> | ||||||
| Status: | RESOLVED FIXED | ||||||||
| Severity: | Normal | CC: | buildbot, commit-queue, kling, psolanki, rniwa | ||||||
| Priority: | P2 | Keywords: | InRadar | ||||||
| Version: | 528+ (Nightly build) | ||||||||
| Hardware: | Unspecified | ||||||||
| OS: | Unspecified | ||||||||
| Attachments: |
|
||||||||
|
Description
Pratik Solanki
2014-06-19 16:59:37 PDT
Created attachment 233393 [details]
Patch
Comment on attachment 233393 [details]
Patch
All right!
Comment on attachment 233393 [details] Patch Attachment 233393 [details] did not pass mac-wk2-ews (mac-wk2): Output: http://webkit-queues.appspot.com/results/4575687415431168 New failing tests: compositing/absolute-position-changed-in-composited-layer.html Created attachment 233406 [details]
Archive of layout-test-results from webkit-ews-12 for mac-mountainlion-wk2
The attached test failures were seen while running run-webkit-tests on the mac-wk2-ews.
Bot: webkit-ews-12 Port: mac-mountainlion-wk2 Platform: Mac OS X 10.8.5
(In reply to comment #3) > (From update of attachment 233393 [details]) > Attachment 233393 [details] did not pass mac-wk2-ews (mac-wk2): > Output: http://webkit-queues.appspot.com/results/4575687415431168 > > New failing tests: > compositing/absolute-position-changed-in-composited-layer.html The patch doesn't touch any Mac code so this failure can't be due to this code change. I'll land manually. Committed r170190: <http://trac.webkit.org/changeset/170190> Comment on attachment 233393 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=233393&action=review > Source/WebCore/platform/network/cf/ResourceHandleCFURLConnectionDelegateWithOperationQueue.cpp:69 > + CFURLRequestSetShouldStartSynchronously(request, 1); I would have expected true or TRUE here instead of 1. |