Bug 134081 - Enable synchronous willSendRequest on iOS
Summary: Enable synchronous willSendRequest on iOS
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: New Bugs (show other bugs)
Version: 528+ (Nightly build)
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Pratik Solanki
URL:
Keywords: InRadar
Depends on:
Blocks:
 
Reported: 2014-06-19 16:59 PDT by Pratik Solanki
Modified: 2014-06-20 12:13 PDT (History)
5 users (show)

See Also:

Attachments
Patch (2.57 KB, patch)
2014-06-19 17:11 PDT, Pratik Solanki 		kling: review+
buildbot: commit-queue-
Details | Formatted Diff | Diff
Archive of layout-test-results from webkit-ews-12 for mac-mountainlion-wk2 (839.82 KB, application/zip)
2014-06-19 23:01 PDT, Build Bot 		no flags Details
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Pratik Solanki 2014-06-19 16:59:37 PDT 
Enable synchronous willSendRequest on iOS
Comment 1 Pratik Solanki 2014-06-19 17:11:28 PDT 
Created attachment 233393 [details]
Patch
Comment 2 Andreas Kling 2014-06-19 17:16:52 PDT 
Comment on attachment 233393 [details]
Patch

All right!
Comment 3 Build Bot 2014-06-19 23:01:43 PDT 
Comment on attachment 233393 [details]
Patch

Attachment 233393 [details] did not pass mac-wk2-ews (mac-wk2):
Output: http://webkit-queues.appspot.com/results/4575687415431168

New failing tests:
compositing/absolute-position-changed-in-composited-layer.html
Comment 4 Build Bot 2014-06-19 23:01:46 PDT 
Created attachment 233406 [details]
Archive of layout-test-results from webkit-ews-12 for mac-mountainlion-wk2

The attached test failures were seen while running run-webkit-tests on the mac-wk2-ews.
Bot: webkit-ews-12  Port: mac-mountainlion-wk2  Platform: Mac OS X 10.8.5
Comment 5 Pratik Solanki 2014-06-20 09:37:24 PDT 
<rdar://problem/17350927>
Comment 6 Pratik Solanki 2014-06-20 09:38:24 PDT 
(In reply to comment #3)
> (From update of attachment 233393 [details])
> Attachment 233393 [details] did not pass mac-wk2-ews (mac-wk2):
> Output: http://webkit-queues.appspot.com/results/4575687415431168
> 
> New failing tests:
> compositing/absolute-position-changed-in-composited-layer.html

The patch doesn't touch any Mac code so this failure can't be due to this code change. I'll land manually.
Comment 7 Pratik Solanki 2014-06-20 10:31:42 PDT 
Committed r170190: <http://trac.webkit.org/changeset/170190>
Comment 8 Darin Adler 2014-06-20 12:13:27 PDT 
Comment on attachment 233393 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=233393&action=review

> Source/WebCore/platform/network/cf/ResourceHandleCFURLConnectionDelegateWithOperationQueue.cpp:69
> +    CFURLRequestSetShouldStartSynchronously(request, 1);

I would have expected true or TRUE here instead of 1.