Bug 134081 – Enable synchronous willSendRequest on iOS

• Status: RESOLVED
• Resolution: FIXED
• Component: New Bugs

[Pratik Solanki]

Enable synchronous willSendRequest on iOS

[Pratik Solanki]

Created attachment 233393 [details]
Patch

[Andreas Kling]

Comment on attachment 233393 [details]
Patch

All right!

[Build Bot]

Comment on attachment 233393 [details]
Patch

Attachment 233393 [details] did not pass mac-wk2-ews (mac-wk2):
Output: http://webkit-queues.appspot.com/results/4575687415431168

New failing tests:
compositing/absolute-position-changed-in-composited-layer.html

[Build Bot]

Created attachment 233406 [details]
Archive of layout-test-results from webkit-ews-12 for mac-mountainlion-wk2

The attached test failures were seen while running run-webkit-tests on the mac-wk2-ews.
Bot: webkit-ews-12  Port: mac-mountainlion-wk2  Platform: Mac OS X 10.8.5

[Pratik Solanki]

<rdar://problem/17350927>

[Pratik Solanki]

(In reply to comment #3)
> (From update of attachment 233393 [details])
> Attachment 233393 [details] did not pass mac-wk2-ews (mac-wk2):
> Output: http://webkit-queues.appspot.com/results/4575687415431168
> 
> New failing tests:
> compositing/absolute-position-changed-in-composited-layer.html

The patch doesn't touch any Mac code so this failure can't be due to this code change. I'll land manually.

[Pratik Solanki]

Committed r170190: <http://trac.webkit.org/changeset/170190>

[Darin Adler]

Comment on attachment 233393 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=233393&action=review

> Source/WebCore/platform/network/cf/ResourceHandleCFURLConnectionDelegateWithOperationQueue.cpp:69
> +    CFURLRequestSetShouldStartSynchronously(request, 1);

I would have expected true or TRUE here instead of 1.