Bug 134073

Summary:

Unfreeze the layer tree on DidFirstVisuallyNonEmptyLayout

Product:

WebKit

Reporter:

Antti Koivisto <koivisto>

Component:

Layout and Rendering

Assignee:

Nobody <webkit-unassigned>

Status:

RESOLVED FIXED

Severity:

Normal

CC:

simon.fraser, thorton, zsborbely.u-szeged

Priority:

Keywords:

InRadar

Version:

528+ (Nightly build)

Hardware:

Unspecified

OS:

Unspecified

Bug Depends on:

134097

Bug Blocks:

Attachments:

Description	Flags
patch	simon.fraser: review+

Description Antti Koivisto 2014-06-19 13:58:12 PDT

DidFirstLayout is too early and we usually get a blank page. This doesn't match existing iOS behavior either.

Comment 1 Antti Koivisto 2014-06-19 14:01:48 PDT

<rdar://problem/17383962>

Comment 2 Antti Koivisto 2014-06-19 14:05:03 PDT

Created attachment 233381 [details]
patch

Comment 3 Simon Fraser (smfr) 2014-06-19 14:09:56 PDT

Comment on attachment 233381 [details]
patch

View in context: https://bugs.webkit.org/attachment.cgi?id=233381&action=review

> Source/WebKit2/WebProcess/WebCoreSupport/WebFrameLoaderClient.cpp:577
> +        if (m_frame == m_frame->page()->mainWebFrame()) {

.isMainFrame()?

> Source/WebKit2/WebProcess/WebCoreSupport/WebFrameLoaderClient.cpp:580
> +                m_didCompletePageTransitionAlready = true;

The "Already" here seems superfluous.

Comment 4 Antti Koivisto 2014-06-19 15:16:04 PDT

http://trac.webkit.org/changeset/170163

Comment 5 Zsolt Borbely 2014-06-20 01:04:33 PDT

It made all performance tests crash on EFL, here is the new bug
report about is: https://bugs.webkit.org/show_bug.cgi?id=134097
Have you got any idea what happened?