| Summary: | Web Inspector: Esc in quick console no longer toggles console drawer | ||||||
|---|---|---|---|---|---|---|---|
| Product: | WebKit | Reporter: | Joseph Pecoraro <joepeck> | ||||
| Component: | Web Inspector | Assignee: | Nobody <webkit-unassigned> | ||||
| Status: | RESOLVED FIXED | ||||||
| Severity: | Normal | CC: | commit-queue, graouts, joepeck, jonowells, timothy, webkit-bug-importer | ||||
| Priority: | P2 | Keywords: | InRadar | ||||
| Version: | 528+ (Nightly build) | ||||||
| Hardware: | All | ||||||
| OS: | All | ||||||
| Attachments: |
|
||||||
|
Description
Joseph Pecoraro
2014-06-19 12:18:03 PDT
This appears to be a CodeMirror 4 regression, because CodeMirror now has a basic keymap for "Esc". In CodeMirror 4 with multiple selection:
Esc - singleSelection
When multiple selections are present, this deselects all but the primary selection.
Maybe, CodeMirror should only prevent default if it actually did something. In any case we may be able to workaround this because we only want to toggle the console when there is no text. This was annoying me quite a bit, so I made a workaround. I think we should still go through and suggest a code mirror change to only prevent default if an action was taken (if multiple selections were collapsed to one). Created attachment 233383 [details]
[PATCH] Proposed Fix
Comment on attachment 233383 [details]
[PATCH] Proposed Fix
Looks good! I agree that CodeMirror should pass on the key if it doesn't do anything.
Comment on attachment 233383 [details] [PATCH] Proposed Fix Clearing flags on attachment: 233383 Committed r170238: <http://trac.webkit.org/changeset/170238> All reviewed patches have been landed. Closing bug. |