Bug 134058

Summary: [CSS Grid Layout] Add GridSpan::iterator
Product: WebKit Reporter: Manuel Rego Casasnovas <rego>
Component: Layout and RenderingAssignee: Manuel Rego Casasnovas <rego>
Status: RESOLVED FIXED    
Severity: Normal CC: andersca, bjonesbe, commit-queue, darin, esprehn+autocc, glenn, jfernandez, kondapallykalyan, simon.fraser, svillar
Priority: P2    
Version: 528+ (Nightly build)   
Hardware: Unspecified   
OS: Unspecified   
Attachments:
Description Flags
Patch
none
Patch none

Manuel Rego Casasnovas
Reported 2014-06-19 03:28:42 PDT
Once GridResolvedPosition patch has landed (bug #131732) it'd be nice to refactor current loops to make them simpler. This has been already implemented in Blink and should be ported into WebKit (see https://codereview.chromium.org/235663004/).
Attachments
Patch (5.20 KB, patch)
2014-06-19 14:45 PDT, Manuel Rego Casasnovas 		no flags
DetailsFormatted DiffDiff
Patch (5.44 KB, patch)
2014-06-19 16:22 PDT, Manuel Rego Casasnovas 		no flags
DetailsFormatted DiffDiff
Show Obsolete (1) View All Add attachment proposed patch, testcase, etc.
Manuel Rego Casasnovas
Comment 1 2014-06-19 14:45:03 PDT
Created attachment 233386 [details] Patch Small refactoring of GridResolvedPosition loops.
Bem Jones-Bey
Comment 2 2014-06-19 15:22:16 PDT
Comment on attachment 233386 [details] Patch Why can't you use a range based for loop?
Manuel Rego Casasnovas
Comment 3 2014-06-19 16:10:50 PDT
(In reply to comment #2) > (From update of attachment 233386 [details]) > Why can't you use a range based for loop? Good idea, I'm changing the patch to use them. Thanks for the suggestion.
Manuel Rego Casasnovas
Comment 4 2014-06-19 16:22:06 PDT
Created attachment 233392 [details] Patch New version using range-based for loops.
Bem Jones-Bey
Comment 5 2014-06-19 21:44:30 PDT
Comment on attachment 233392 [details] Patch iterators are awesome. r=me.
Manuel Rego Casasnovas
Comment 6 2014-06-20 01:29:30 PDT
Comment on attachment 233392 [details] Patch Clearing flags on attachment: 233392 Committed r170182: <http://trac.webkit.org/changeset/170182>
Manuel Rego Casasnovas
Comment 7 2014-06-20 01:29:38 PDT
All reviewed patches have been landed. Closing bug.
Note You need to log in before you can comment on or make changes to this bug.